-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow parsing Bitcoin deposit memo with inscription and add E2E test for parsing #2727
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitSmiley
requested review from
brewmaster012,
kingpinXD,
lumtis,
ws4charlie,
skosito,
swift1337 and
fbac
as code owners
August 16, 2024 03:57
Co-authored-by: Lucas Bertrand <[email protected]>
It seems it breaks the deposit BTC test: https://github.com/zeta-chain/node/actions/runs/10471358149/job/28998509065 Is the change supposed to be backward compatible |
Co-authored-by: Lucas Bertrand <[email protected]>
Co-authored-by: Lucas Bertrand <[email protected]>
Co-authored-by: Lucas Bertrand <[email protected]>
@lumtis sorry man, I just fixed the linting and change log, please help run the pipeline again. |
8 tasks
Opening back for |
lumtis
approved these changes
Sep 14, 2024
fbac
approved these changes
Sep 19, 2024
Closing in favor of #2957 as discussed on Slack |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding e2e test for detecting memo from inscription.
The current
btcutil
does not have enough tapscript support, in this case, a nodejs sidecar to handle inscription txn generation is used instead. This is not intrusive and can be quickly removed once btcutil is upgraded.How Has This Been Tested?
Summary by CodeRabbit
New Features
ScriptBuilder
for constructing tapscripts used in Bitcoin transactions.Bug Fixes
Documentation
tsconfig.json
for TypeScript setup.Chores