Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow parsing Bitcoin deposit memo with inscription and add E2E test for parsing #2727

Closed
wants to merge 48 commits into from

Merge branch 'develop' into e2e

4b4df76
Select commit
Loading
Failed to load commit list.
Closed

feat: allow parsing Bitcoin deposit memo with inscription and add E2E test for parsing #2727

Merge branch 'develop' into e2e
4b4df76
Select commit
Loading
Failed to load commit list.
GitGuardian / GitGuardian Security Checks failed Sep 19, 2024 in 39s

6 secrets uncovered!

6 secrets were uncovered from the scan of 48 commits in your pull request. ❌

Please have a look to GitGuardian findings and remediate in order to secure your code.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

Details

🔎 Detected hardcoded secrets in your pull request

  • Pull request #2727: e2e 👉 develop
GitGuardian id GitGuardian status Secret Commit Filename
13392123 Triggered Generic High Entropy Secret 161d543 zetaclient/chains/solana/signer/signer_test.go View secret
13392123 Triggered Generic High Entropy Secret e2414d8 zetaclient/chains/solana/signer/signer_test.go View secret
13340122 Triggered Generic High Entropy Secret e2414d8 zetaclient/chains/solana/signer/signer_test.go View secret
13340122 Triggered Generic High Entropy Secret 161d543 zetaclient/chains/solana/signer/signer_test.go View secret
13340122 Triggered Generic High Entropy Secret e2414d8 zetaclient/chains/solana/signer/signer_test.go View secret
13340122 Triggered Generic High Entropy Secret 161d543 zetaclient/chains/solana/signer/signer_test.go View secret

🛠 Guidelines to remediate hardcoded secrets

  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.