Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow parsing Bitcoin deposit memo with inscription and add E2E test for parsing #2727
feat: allow parsing Bitcoin deposit memo with inscription and add E2E test for parsing #2727
Changes from 22 commits
5109776
3943574
ffaa63c
8405c85
4aee797
a7db462
73c6695
cb60c4e
a43f6ec
58d51d2
cb59e0b
a0c0ab1
f408186
8582d87
1f70654
508095a
306856d
475d8e0
d14033b
c209bf9
3c47efb
e2414d8
4e7b695
161d543
06bf0bf
b56767c
2da0d34
5f3ade1
77f71c2
f2bffb2
efcebdc
2ed136c
bc02de7
7bf9b07
7ae9955
9e498bc
4e69799
152b0d7
b341832
4133914
7e394eb
4fd2d19
b49c074
7b0ca65
9e38b18
3478967
c7607fb
4b4df76
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not introduce nodejs for test cases but write them with existing go tooling.
Regarding update of
btcsuite/btcd
- I investigated this as as of now it's not trivial because we have a downstream deps of btcd v1:zeta-chain/node
. Can be updatedzeta-chain/go-tss
(thorchain's fork). Can be updatedtss-lib
(thorchain). It usesgithub.com/btcsuite/btcd
instead ofgithub.com/btcsuite/btcd/v2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So probably makes sense to cherry pick missing features from there and implement it natively using zeta's E2E suite.
cc @lumtis @ws4charlie
#2728
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created issue for the improvement #2900
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good to add
testnet()
as well. Features typically goes to ZetaChain testnet and then mainnet.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add a
profiles
to allow manually setting when this image should be spawnedcc @gartnera in case he has inputs on this