-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deprecated usage of lock_memory API #1970
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, but there is a logical issue here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Sai Kishor Kothakota <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1970 +/- ##
==========================================
- Coverage 88.11% 88.04% -0.07%
==========================================
Files 121 121
Lines 13224 13227 +3
Branches 1193 1195 +2
==========================================
- Hits 11652 11646 -6
- Misses 1136 1141 +5
- Partials 436 440 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please fix the pre-commit issue (run pre-commit run --all
)
oh sorry, I've forgotten that draft PR. |
Fixed the pre-commit issue.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!
(cherry picked from commit 52a2ffd)
(cherry picked from commit 52a2ffd) Co-authored-by: Sudip Roy <[email protected]>
Contributions via pull requests are much appreciated. Before sending us a pull request, please ensure that:
To send us a pull request, please:
colcon test
andpre-commit run
(requires you to install pre-commit bypip3 install pre-commit
)