Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecated usage of lock_memory API #1970

Merged
merged 5 commits into from
Dec 23, 2024

Conversation

imsudiproy
Copy link
Contributor

Contributions via pull requests are much appreciated. Before sending us a pull request, please ensure that:

  1. Limited scope. Your PR should do one thing or one set of things. Avoid adding “random fixes” to PRs. Put those on separate PRs.
  2. Give your PR a descriptive title. Add a short summary, if required.
  3. Make sure the pipeline is green.
  4. Don’t be afraid to request reviews from maintainers.
  5. New code = new tests. If you are adding new functionality, always make sure to add some tests exercising the code and serving as live documentation of your original intention.

To send us a pull request, please:

  • Fork the repository.
  • Modify the source; please focus on the specific change you are contributing. If you also reformat all the code, it will be hard for us to focus on your change.
  • Ensure local tests pass. (colcon test and pre-commit run (requires you to install pre-commit by pip3 install pre-commit)
  • Commit to your fork using clear commit messages.
  • Send a pull request, answering any default questions in the pull request interface.
  • Pay attention to any automated CI failures reported in the pull request, and stay involved in the conversation.

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, but there is a logical issue here

controller_manager/src/ros2_control_node.cpp Outdated Show resolved Hide resolved
saikishor
saikishor previously approved these changes Dec 23, 2024
Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This looks like a duplicate of #1892

However, considering it as a first issue. It's fine

controller_manager/src/ros2_control_node.cpp Outdated Show resolved Hide resolved
Co-authored-by: Sai Kishor Kothakota <[email protected]>
saikishor
saikishor previously approved these changes Dec 23, 2024
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 88.04%. Comparing base (03bf0e8) to head (1ec9b01).

Files with missing lines Patch % Lines
controller_manager/src/ros2_control_node.cpp 0.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1970      +/-   ##
==========================================
- Coverage   88.11%   88.04%   -0.07%     
==========================================
  Files         121      121              
  Lines       13224    13227       +3     
  Branches     1193     1195       +2     
==========================================
- Hits        11652    11646       -6     
- Misses       1136     1141       +5     
- Partials      436      440       +4     
Flag Coverage Δ
unittests 88.04% <0.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
controller_manager/src/ros2_control_node.cpp 61.81% <0.00%> (-4.22%) ⬇️

... and 4 files with indirect coverage changes

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix the pre-commit issue (run pre-commit run --all)

@christophfroehlich
Copy link
Contributor

LGTM

This looks like a duplicate of #1892

However, considering it as a first issue. It's fine

oh sorry, I've forgotten that draft PR.

@imsudiproy
Copy link
Contributor Author

please fix the pre-commit issue (run pre-commit run --all)

Fixed the pre-commit issue.

root@1bd3e3af4a7d:~/ros2_humble_ws/src/ros2_control# pre-commit run --all
check for added large files..............................................Passed
check python ast.........................................................Passed
check for case conflicts.................................................Passed
check docstring is first.................................................Passed
check for merge conflicts................................................Passed
check for broken symlinks............................(no files to check)Skipped
check xml................................................................Passed
check yaml...............................................................Passed
debug statements (python)................................................Passed
fix end of files.........................................................Passed
mixed line ending........................................................Passed
trim trailing whitespace.................................................Passed
fix utf-8 byte order marker..............................................Passed
pyupgrade................................................................Passed
pydocstyle...............................................................Passed
black....................................................................Passed
flake8...................................................................Passed
clang-format.............................................................Passed
ament_cppcheck...........................................................Passed
ament_cpplint............................................................Passed
ament_lint_cmake.........................................................Passed
ament_copyright..........................................................Passed
doc8.....................................................................Passed
rst ``code`` is two backticks............................................Passed
rst directives end with two colons.......................................Passed
rst ``inline code`` next to normal text..................................Passed
codespell................................................................Passed
Validate GitHub Workflows................................................Passed
Validate GitHub Actions..............................(no files to check)Skipped
Validate Dependabot Config (v2)..........................................Passed

Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@bmagyar bmagyar merged commit 52a2ffd into ros-controls:master Dec 23, 2024
1 check passed
@bmagyar bmagyar added the backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS2 humble. label Dec 23, 2024
mergify bot pushed a commit that referenced this pull request Dec 23, 2024
saikishor pushed a commit that referenced this pull request Dec 23, 2024
(cherry picked from commit 52a2ffd)

Co-authored-by: Sudip Roy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS2 humble.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants