Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ros2_control_node to fix deprecation from realtime_tools. #1967

Closed

Conversation

kumar-sanjeeev
Copy link
Contributor

Updated code as per API of lock_memory to fix deprecation from realtime_tools.

Copy link
Contributor

mergify bot commented Dec 21, 2024

@kumar-sanjeeev, all pull requests must be targeted towards the master development branch.
Once merged into master, it is possible to backport to humble, but it must be in master
to have these changes reflected into new distributions.

Copy link

codecov bot commented Dec 21, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 62.92%. Comparing base (5c5a171) to head (84ea285).
Report is 3 commits behind head on humble.

Files with missing lines Patch % Lines
controller_manager/src/ros2_control_node.cpp 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           humble    #1967   +/-   ##
=======================================
  Coverage   62.92%   62.92%           
=======================================
  Files         109      109           
  Lines       12504    12504           
  Branches     8481     8482    +1     
=======================================
  Hits         7868     7868           
  Misses        852      852           
  Partials     3784     3784           
Flag Coverage Δ
unittests 62.92% <50.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
controller_manager/src/ros2_control_node.cpp 67.34% <50.00%> (ø)

@bmagyar
Copy link
Member

bmagyar commented Dec 23, 2024

Thank you!

This I believe is equivalent to #1970 but it has the logical issue of the unintended call. I've marked #1970 for backporting to Humble so you should get a fix soon. Once the backport works, I'll close this one.

If you'd like good first issues you are either welcome to look in here or finding a deprecation warning in ros2_controllers or ros2_control local builds to fix ;)

@saikishor
Copy link
Member

Closed in favor #1971

@saikishor saikishor closed this Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants