Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor fix to eks-starter.yaml #4337

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Conversation

guyarad
Copy link
Contributor

@guyarad guyarad commented Oct 31, 2023

Describe your changes

  • eks-starter.yaml is missing a database username - probably a better practice to be explicit about it. Also, since it's meant for less advanced users, it will help them remember to provide this information.
  • deployment.yaml template - readiness and liveness probes had the wrong port (and probably missing initial delay)

Check all the applicable boxes

  • I updated the documentation accordingly. - not relevant
  • All new and existing tests passed.
  • All commits are signed-off.

@welcome
Copy link

welcome bot commented Oct 31, 2023

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

  • Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
  • Sign off your commits (Reference: DCO Guide).

@kumare3
Copy link
Contributor

kumare3 commented Oct 31, 2023

Cc @davidmirror-ops

@davidmirror-ops
Copy link
Contributor

Thank you @guyarad

Could you run make helm and push it again?

@guyarad guyarad force-pushed the master branch 2 times, most recently from 0214b60 to d08a4c2 Compare October 31, 2023 17:26
fixes deployment template readiness and liveness probes with correct port

Signed-off-by: Guy Arad <[email protected]>
Copy link
Contributor

@davidmirror-ops davidmirror-ops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@davidmirror-ops davidmirror-ops merged commit ded4a2e into flyteorg:master Nov 6, 2023
16 checks passed
Copy link

welcome bot commented Nov 6, 2023

Congrats on merging your first pull request! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants