minor fix to eks-starter.yaml

fixes deployment template readiness and liveness probes with correct port Signed-off-by: Guy Arad <[email protected]>
flyteorg · Nov 5, 2023 · 24be4d9 · 24be4d9
1 parent 6425a2a
commit 24be4d9
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 2 deletions.
diff --git a/charts/flyte-binary/eks-starter.yaml b/charts/flyte-binary/eks-starter.yaml
@@ -1,8 +1,9 @@
 configuration:
   database:
+    username: <DB_USERNAME>
     password: <DB_PASSWORD>
     host: <RDS_HOST_DNS>
-    dbname: app  # what is this? why not flyteadmin or flyte?
+    dbname: flyteadmin (<INITAL_DB>)
   storage:
     metadataContainer: <BUCKET_NAME>
     userDataContainer: <USER_DATA_BUCKET_NAME>

diff --git a/charts/flyte-binary/templates/deployment.yaml b/charts/flyte-binary/templates/deployment.yaml
@@ -202,6 +202,7 @@ spec:
             httpGet:
               path: /healthcheck
               port: http
+            initialDelaySeconds: 30
           {{- end }}
           {{- if .Values.deployment.resources }}
           resources: {{- toYaml .Values.deployment.resources | nindent 12 }}

diff --git a/deployment/sandbox-binary/flyte_sandbox_binary_helm_generated.yaml b/deployment/sandbox-binary/flyte_sandbox_binary_helm_generated.yaml
@@ -422,6 +422,7 @@ spec:
             httpGet:
               path: /healthcheck
               port: http
+            initialDelaySeconds: 30
           volumeMounts:
             - name: cluster-resource-templates
               mountPath: /etc/flyte/cluster-resource-templates

diff --git a/script/generate_helm.sh b/script/generate_helm.sh
@@ -4,9 +4,14 @@ set -ex
 
 echo "Generating Helm"
 
-curl https://raw.githubusercontent.com/helm/helm/main/scripts/get-helm-3 | bash
+HELM_SKIP_INSTALL=${HELM_SKIP_INSTALL:-false}
+
+if [ "${HELM_SKIP_INSTALL}" != "true" ]; then
+    curl https://raw.githubusercontent.com/helm/helm/main/scripts/get-helm-3 | bash
+fi
 
 helm version
+
 # All the values files to be built
 DEPLOYMENT_CORE=${1:-eks gcp}