Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor fix to eks-starter.yaml #4337

Merged
merged 1 commit into from
Nov 6, 2023
Merged

minor fix to eks-starter.yaml #4337

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion charts/flyte-binary/eks-starter.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
configuration:
database:
username: <DB_USERNAME>
password: <DB_PASSWORD>
host: <RDS_HOST_DNS>
dbname: app # what is this? why not flyteadmin or flyte?
dbname: flyteadmin (<INITAL_DB>)
guyarad marked this conversation as resolved.
Show resolved Hide resolved
storage:
metadataContainer: <BUCKET_NAME>
userDataContainer: <USER_DATA_BUCKET_NAME>
Expand Down
1 change: 1 addition & 0 deletions charts/flyte-binary/templates/deployment.yaml
View file
Open in desktop
guyarad marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,7 @@ spec:
httpGet:
path: /healthcheck
port: http
initialDelaySeconds: 30
{{- end }}
{{- if .Values.deployment.resources }}
resources: {{- toYaml .Values.deployment.resources | nindent 12 }}
Expand Down
1 change: 1 addition & 0 deletions deployment/sandbox-binary/flyte_sandbox_binary_helm_generated.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,6 +422,7 @@ spec:
httpGet:
path: /healthcheck
port: http
initialDelaySeconds: 30
volumeMounts:
- name: cluster-resource-templates
mountPath: /etc/flyte/cluster-resource-templates
Expand Down
7 changes: 6 additions & 1 deletion script/generate_helm.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,14 @@ set -ex

echo "Generating Helm"

curl https://raw.githubusercontent.com/helm/helm/main/scripts/get-helm-3 | bash
HELM_SKIP_INSTALL=${HELM_SKIP_INSTALL:-false}

if [ "${HELM_SKIP_INSTALL}" != "true" ]; then
curl https://raw.githubusercontent.com/helm/helm/main/scripts/get-helm-3 | bash
fi

helm version

# All the values files to be built
DEPLOYMENT_CORE=${1:-eks gcp}

Expand Down
Loading