fixes deployment template readiness and liveness probes with correct …

…port Signed-off-by: Guy Arad <[email protected]>
flyteorg · Oct 31, 2023 · d08a4c2 · d08a4c2
1 parent 0bbedeb
commit d08a4c2
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 5 deletions.
diff --git a/charts/flyte-binary/templates/deployment.yaml b/charts/flyte-binary/templates/deployment.yaml
@@ -192,15 +192,17 @@ spec:
           {{- else }}
             httpGet:
               path: /healthcheck
-              port: http
+              port: 8088
+            initialDelaySeconds: 60
           {{- end }}
           readinessProbe:
           {{- if .Values.deployment.readinessProbe }}
           {{- tpl ( .Values.deployment.readinessProbe | toYaml ) . | nindent 12 }}
           {{- else }}
             httpGet:
               path: /healthcheck
-              port: http
+              port: 8088
+            initialDelaySeconds: 60
           {{- end }}
           {{- if .Values.deployment.resources }}
           resources: {{- toYaml .Values.deployment.resources | nindent 12 }}

diff --git a/deployment/sandbox-binary/flyte_sandbox_binary_helm_generated.yaml b/deployment/sandbox-binary/flyte_sandbox_binary_helm_generated.yaml
@@ -416,11 +416,13 @@ spec:
           livenessProbe:
             httpGet:
               path: /healthcheck
-              port: http
+              port: 8088
+            initialDelaySeconds: 60
           readinessProbe:
             httpGet:
               path: /healthcheck
-              port: http
+              port: 8088
+            initialDelaySeconds: 60
           volumeMounts:
             - name: cluster-resource-templates
               mountPath: /etc/flyte/cluster-resource-templates

diff --git a/script/generate_helm.sh b/script/generate_helm.sh
@@ -4,9 +4,14 @@ set -ex
 
 echo "Generating Helm"
 
-curl https://raw.githubusercontent.com/helm/helm/main/scripts/get-helm-3 | bash
+HELM_SKIP_INSTALL=${HELM_SKIP_INSTALL:-false}
+
+if [ "${HELM_SKIP_INSTALL}" != "true" ]; then
+    curl https://raw.githubusercontent.com/helm/helm/main/scripts/get-helm-3 | bash
+fi
 
 helm version
+
 # All the values files to be built
 DEPLOYMENT_CORE=${1:-eks gcp}