Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename model_name and model_name_or_path parameters as model #6534

Closed
bilgeyucel opened this issue Dec 13, 2023 · 3 comments
Closed

Rename model_name and model_name_or_path parameters as model #6534

bilgeyucel opened this issue Dec 13, 2023 · 3 comments
Assignees
Labels
2.x Related to Haystack v2.0 P1 High priority, add to the next sprint
Milestone

Comments

@bilgeyucel
Copy link
Contributor

Is your feature request related to a problem? Please describe.
As a user, I'd like to have a similar interface for each Generator (possibly for all components accepting a model name) to pass the model name

Describe the solution you'd like
We have discussed that parameters should be named as model but the most important point is to have consistency

Describe alternatives you've considered
Having more documentation around the parameter names can be another solution

Additional context
N/A

@bilgeyucel
Copy link
Contributor Author

If there's nothing against it, it would be nice to have the same convention for all components including embedders and transcribers

@ZanSara
Copy link
Contributor

ZanSara commented Jan 17, 2024

For the related work on the integrations, see deepset-ai/haystack-core-integrations#227

@ZanSara ZanSara closed this as completed Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x Related to Haystack v2.0 P1 High priority, add to the next sprint
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants