Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remaned model_name or nodel_name_or_path to model #6637

Closed
wants to merge 5 commits into from
Closed

remaned model_name or nodel_name_or_path to model #6637

wants to merge 5 commits into from

Conversation

sahusiddharth
Copy link
Contributor

@sahusiddharth sahusiddharth requested a review from a team as a code owner December 23, 2023 04:51
@sahusiddharth sahusiddharth requested review from masci and removed request for a team December 23, 2023 04:51
@github-actions github-actions bot added topic:tests 2.x Related to Haystack v2.0 type:documentation Improvements on the docs labels Dec 23, 2023
@sahusiddharth sahusiddharth requested a review from a team as a code owner December 23, 2023 05:59
@sahusiddharth sahusiddharth requested review from dfokina and removed request for a team December 23, 2023 05:59
@masci masci requested review from ZanSara and removed request for masci January 8, 2024 09:12
@ZanSara
Copy link
Contributor

ZanSara commented Jan 9, 2024

Hey @sahusiddharth, you haven't run the pre-commit hooks and the CI is failing. Could you make sure to run them? You can find instructions here: https://github.com/deepset-ai/haystack/blob/main/CONTRIBUTING.md

@sahusiddharth
Copy link
Contributor Author

@ZanSara I'll do it and let you know

@sahusiddharth sahusiddharth deleted the feat/rename-model_name-and-model_name_or_path-parameters-as-model branch January 9, 2024 17:33
@sahusiddharth sahusiddharth restored the feat/rename-model_name-and-model_name_or_path-parameters-as-model branch January 9, 2024 17:40
@sahusiddharth
Copy link
Contributor Author

@ZanSara i was facing have created another PR #6715

@sahusiddharth sahusiddharth deleted the feat/rename-model_name-and-model_name_or_path-parameters-as-model branch January 10, 2024 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfokina dfokina Awaiting requested review from dfokina dfokina is a code owner automatically assigned from deepset-ai/documentation

@ZanSara ZanSara Awaiting requested review from ZanSara

Assignees
No one assigned
Labels
2.x Related to Haystack v2.0 topic:tests type:documentation Improvements on the docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename model_name and model_name_or_path parameters as model
3 participants
@sahusiddharth @ZanSara @masci