Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Rename model_name_or_path to model in TransformersSimilarityRanker #6734

Merged
merged 5 commits into from
Jan 12, 2024

Conversation

ZanSara
Copy link
Contributor

@ZanSara ZanSara commented Jan 12, 2024

Related Issues

Proposed Changes:

  • Rename model_name_or_path to model in TransformersSimilarityRanker.

How did you test it?

Local tests run, CI

Notes for the reviewer

n/a

Checklist

@ZanSara ZanSara requested review from a team as code owners January 12, 2024 13:29
@ZanSara ZanSara requested review from dfokina and silvanocerza and removed request for a team January 12, 2024 13:29
@github-actions github-actions bot added topic:tests 2.x Related to Haystack v2.0 type:documentation Improvements on the docs labels Jan 12, 2024
@coveralls
Copy link
Collaborator

coveralls commented Jan 12, 2024

Pull Request Test Coverage Report for Build 7502910512

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.126%

Totals Coverage Status
Change from base Build 7502449893: 0.0%
Covered Lines: 4284
Relevant Lines: 4917

💛 - Coveralls

@ZanSara ZanSara merged commit 0616197 into main Jan 12, 2024
22 checks passed
@ZanSara ZanSara deleted the rename-model-param-rankers branch January 12, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x Related to Haystack v2.0 topic:tests type:documentation Improvements on the docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants