Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rename model_name or model_name_or_path to model in generators #6715

Conversation

sahusiddharth
Copy link
Contributor

@sahusiddharth sahusiddharth commented Jan 10, 2024

Related Issues

Proposed Changes:

  • Rename model_name or model_name_or_path to model in all Generator classes.
  • Addresses the issue related to inconsistent parameter naming for model names across Generators
  • Enhances code readability and maintains a standardized interface for users.

How did you test it?

CI

Notes for the reviewer

n/a

Checklist

@sahusiddharth sahusiddharth requested review from a team as code owners January 10, 2024 03:21
@sahusiddharth sahusiddharth requested review from dfokina and anakin87 and removed request for a team January 10, 2024 03:21
@github-actions github-actions bot added topic:tests 2.x Related to Haystack v2.0 type:documentation Improvements on the docs labels Jan 10, 2024
@coveralls
Copy link
Collaborator

coveralls commented Jan 10, 2024

Pull Request Test Coverage Report for Build 7500473866

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.074%

Totals Coverage Status
Change from base Build 7490996754: 0.0%
Covered Lines: 4217
Relevant Lines: 4843

💛 - Coveralls

@anakin87 anakin87 requested review from ZanSara and removed request for anakin87 January 10, 2024 08:23
@ZanSara ZanSara changed the title Renamed model name or model name or path to model feat: rename model_name or model_name_or_path to model in generators Jan 10, 2024
@ZanSara
Copy link
Contributor

ZanSara commented Jan 10, 2024

Hey @sahusiddharth, this is a breaking change and quite an impactful one, so I took the liberty of improving a bit your PR (title, description and release notes). Otherwise it looks good, so I'll approve and merge as soon as the CI is green again.

Thank you for your work!

@ZanSara ZanSara merged commit dbdeb82 into deepset-ai:main Jan 12, 2024
22 checks passed
@sahusiddharth sahusiddharth deleted the renamed-model_name-or-model_name_or_path-to-model branch January 18, 2024 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x Related to Haystack v2.0 topic:tests type:documentation Improvements on the docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants