-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: rename model_name
or model_name_or_path
to model
in generators
#6715
Merged
ZanSara
merged 6 commits into
deepset-ai:main
from
sahusiddharth:renamed-model_name-or-model_name_or_path-to-model
Jan 12, 2024
Merged
feat: rename model_name
or model_name_or_path
to model
in generators
#6715
ZanSara
merged 6 commits into
deepset-ai:main
from
sahusiddharth:renamed-model_name-or-model_name_or_path-to-model
Jan 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sahusiddharth
requested review from
dfokina and
anakin87
and removed request for
a team
January 10, 2024 03:21
github-actions
bot
added
topic:tests
2.x
Related to Haystack v2.0
type:documentation
Improvements on the docs
labels
Jan 10, 2024
Pull Request Test Coverage Report for Build 7500473866
💛 - Coveralls |
ZanSara
changed the title
Renamed model name or model name or path to model
feat: rename Jan 10, 2024
model_name
or model_name_or_path
to model
in generators
ZanSara
reviewed
Jan 10, 2024
releasenotes/notes/renamed-model_name-or-model_name_or_path-to-model-184490cbb66c4d7c.yaml
Outdated
Show resolved
Hide resolved
…-model-184490cbb66c4d7c.yaml
Hey @sahusiddharth, this is a breaking change and quite an impactful one, so I took the liberty of improving a bit your PR (title, description and release notes). Otherwise it looks good, so I'll approve and merge as soon as the CI is green again. Thank you for your work! |
ZanSara
approved these changes
Jan 12, 2024
sahusiddharth
deleted the
renamed-model_name-or-model_name_or_path-to-model
branch
January 18, 2024 02:15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
model_name
andmodel_name_or_path
parameters asmodel
#6534Proposed Changes:
model_name
ormodel_name_or_path
tomodel
in all Generator classes.How did you test it?
CI
Notes for the reviewer
n/a
Checklist
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
.