Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename model_name and model_name_or_path parameters as model in all integrations #227

Closed
13 tasks done
ZanSara opened this issue Jan 17, 2024 · 0 comments
Closed
13 tasks done
Assignees
Labels
bug Something isn't working P1

Comments

@ZanSara
Copy link
Contributor

ZanSara commented Jan 17, 2024

Related to deepset-ai/haystack#6534

Is your feature request related to a problem? Please describe.

As a user, I'd like to have a similar interface for each Generator (possibly for all components accepting a model name) to pass the model name

Describe the solution you'd like

We have discussed that parameters should be named as model but the most important point is to have consistency.

TODOs:

@ZanSara ZanSara added the bug Something isn't working label Jan 17, 2024
@ZanSara ZanSara self-assigned this Jan 17, 2024
@ZanSara ZanSara added the P1 label Jan 17, 2024
@ZanSara ZanSara closed this as completed Jan 22, 2024
@masci masci reopened this Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P1
Projects
None yet
Development

No branches or pull requests

3 participants