Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cohere] Add text and document embedders #80

Merged
merged 11 commits into from
Dec 7, 2023
Merged

[cohere] Add text and document embedders #80

merged 11 commits into from
Dec 7, 2023

Conversation

masci
Copy link
Contributor

@masci masci commented Dec 5, 2023 •
edited
Loading

@masci masci mentioned this pull request Dec 5, 2023
Closed
@vrunm
Copy link
Contributor

vrunm commented Dec 6, 2023

@masci I saw that you moved the PR from haystack to the haystack-core-integrations repo. Do any changes need to be made to this PR?

@masci masci marked this pull request as ready for review December 6, 2023 08:56
@masci masci requested a review from a team as a code owner December 6, 2023 08:56
@masci masci requested review from julian-risch and removed request for a team December 6, 2023 08:56
@masci
Copy link
Contributor Author

masci commented Dec 6, 2023

@vrunm PR is good to go!

@CLAassistant
Copy link

CLAassistant commented Dec 6, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

julian-risch
julian-risch requested changes Dec 6, 2023
View reviewed changes
Copy link
Member

@julian-risch julian-risch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good to me, almost ready to go. I would like to have the CohereDocumentEmbedder also work with empty lists of documents and suggested a change of an if condition and the addition of a test case. Everything else is ready to be merged. 👍

integrations/cohere/src/cohere_haystack/embedders/document_embedder.py Outdated Show resolved Hide resolved
integrations/cohere/src/cohere_haystack/generator.py Show resolved Hide resolved
@masci masci mentioned this pull request Dec 6, 2023
Merged
@julian-risch julian-risch self-requested a review December 7, 2023 08:06
julian-risch
julian-risch approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@julian-risch julian-risch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍 Great to see you already removed LazyImport from the other integrations in a separate PR.

@julian-risch julian-risch merged commit 2627712 into main Dec 7, 2023
7 checks passed
@julian-risch julian-risch deleted the cohere-embedders branch December 7, 2023 08:09
@masci masci mentioned this pull request Dec 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julian-risch julian-risch julian-risch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@masci @vrunm @CLAassistant @julian-risch