feat: Add CohereTextEmbedder CohereDocumentEmbedder
#5831
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
topic:tests
type:documentation
vrunm
force-pushed
the
add_cohere_text_embedder
branch
from
893fb61 to
ca47506
Compare
vrunm
changed the title
CohereTextEmbedderCohereTextEmbedder CohereDocumentEmbedder
masci
suggested changes
Oct 3, 2023
There was a problem hiding this comment.
Apologies for the latency here!
I took a first pass and left a couple of comments, but I have a general question: why the two embedders look so different? Say, one uses the async client and the other doesn't... Any additional info that can help me better understanding the code much appreciated!
haystack/preview/components/embedders/cohere_document_embedder.py
Outdated
Show resolved
Hide resolved
dfokina
reviewed
Oct 3, 2023
haystack/preview/components/embedders/cohere_document_embedder.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Daria Fokina <[email protected]>
Co-authored-by: Daria Fokina <[email protected]>
masci
suggested changes
Oct 18, 2023
haystack/preview/components/embedders/cohere_document_embedder.py
Outdated
Show resolved
Hide resolved
haystack/preview/components/embedders/cohere_document_embedder.py
Outdated
Show resolved
Hide resolved
Closed
|
Superseded by deepset-ai/haystack-core-integrations#80 |
|
deepset-ai/haystack-core-integrations#80 is ready for review, closing this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
Add
CohereTextEmbedder, a component that uses Cohere embedding models to embed strings into vectors.Add
CohereDocumentEmbedder, a component that embeds a list of Documents.coheresdk instead of the post requests based implementation in V1.coheresdk (library).How did you test it?
Added unit tests.
Notes for the reviewer
"cohere"needs to be added as a dependency in the haystack-preview-package.Supported Cohere Embedding Models and their embedding dimensions:
Cohere Embedding Models supported in 1.0 API that don't work anymore:
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.