Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove LazyImport from integrations #83

Merged
merged 3 commits into from
Dec 6, 2023
Merged

chore: remove LazyImport from integrations #83

merged 3 commits into from
Dec 6, 2023

Conversation

masci
Copy link
Contributor

@masci masci commented Dec 6, 2023

Since integration packages depend on the respective external libraries, we should assume the dependency is there, without attempting to lazy-import it.

Note: I didn't remove it from cohere because that's done as part of #80, to avoid conflicts

@masci masci requested a review from a team as a code owner December 6, 2023 16:14
@masci masci requested review from vblagoje and removed request for a team December 6, 2023 16:14
@anakin87 anakin87 merged commit 0634b23 into main Dec 6, 2023
8 checks passed
@anakin87 anakin87 deleted the massi/no-lazy branch December 6, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants