Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cohere Embedders #5621

Closed
Tracked by #5312
anakin87 opened this issue Aug 25, 2023 · 5 comments
Closed
Tracked by #5312

Cohere Embedders #5621

anakin87 opened this issue Aug 25, 2023 · 5 comments
Assignees
@masci
Labels
2.x Related to Haystack v2.0 good first issue Good for newcomers

Comments

@anakin87
Copy link
Member

anakin87 commented Aug 25, 2023 •
edited
Loading

According to the Embedders proposal,
we should start implementing 2 classes:

  • CohereTextEmbedder
  • CohereDocumentEmbedder
@anakin87 anakin87 mentioned this issue Aug 25, 2023
Closed
@ZanSara ZanSara added the 2.x Related to Haystack v2.0 label Aug 28, 2023
@masci masci added the good first issue Good for newcomers label Sep 13, 2023
@vrunm
Copy link
Contributor

vrunm commented Sep 16, 2023

I would like to work on this issue.
I have opened a PR for adding the Cohere Embedder Component.

@anakin87
Copy link
Member Author

Nice!

We are currently working on OpenAI Embedders for Haystack 2.0 (see #5801 and #5822).
We still have to define some details, but you can start looking at them.

(Don't forget to read the Contributing guidelines 😉)

@vrunm vrunm mentioned this issue Sep 16, 2023
Closed
@masci masci self-assigned this Sep 26, 2023
@dhivyeshrk
Copy link

Hi @anakin87! If the issue is still open, I would be happy to contribute. Could you assign this to me ?

@anakin87
Copy link
Member Author

Hey, @dhivyeshrk, and thanks for your interest...
This issue is being addressed in #5831.
So I would suggest that you pick another open issue.

@masci
Copy link
Contributor

masci commented Dec 11, 2023

Fixed in deepset-ai/haystack-core-integrations#80

@masci masci closed this as completed Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@masci masci

Labels
2.x Related to Haystack v2.0 good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add CohereTextEmbedder CohereDocumentEmbedder vrunm/haystack
6 participants
@masci @ZanSara @bilgeyucel @anakin87 @vrunm @dhivyeshrk