Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename MsgRemoveForeignCoin name field into zrc20Address and remove crosschain param #1722

Closed
wants to merge 6 commits into from
Closed

refactor: rename MsgRemoveForeignCoin name field into zrc20Address and remove crosschain param #1722

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c9fbab6
Rename Name to ZRC20Address for MsgRemoveForeignCoin
ptdatta Feb 6, 2024
c44e9ae
Removed Enabled for Crosschain
ptdatta Feb 6, 2024
afc38c2
Fix errors
ptdatta Feb 7, 2024
55810b9
Added openapi.swagger.yaml
ptdatta Feb 9, 2024
6e52ff0
Updated Changelog
ptdatta Feb 14, 2024
b2004ef
Merge branch 'develop' into my-dev
CharlieMc0 Mar 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/spec/fungible/messages.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ Authorized: admin policy group 2.
```proto
message MsgRemoveForeignCoin {
string creator = 1;
string name = 2;
string zrc20_address = 2;
}
```

Expand Down
1 change: 0 additions & 1 deletion proto/crosschain/params.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,4 @@ option go_package = "github.com/zeta-chain/zetacore/x/crosschain/types";
// Params defines the parameters for the module.
message Params {
option (gogoproto.goproto_stringer) = false;
bool enabled = 1;
}
2 changes: 1 addition & 1 deletion proto/fungible/tx.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ message MsgDeployFungibleCoinZRC20Response {

message MsgRemoveForeignCoin {
string creator = 1;
string name = 2;
string zrc20_address = 2; //zrc20 address
lumtis marked this conversation as resolved.
Show resolved Hide resolved
}

message MsgRemoveForeignCoinResponse {}
Expand Down
56 changes: 7 additions & 49 deletions x/crosschain/types/params.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions x/fungible/types/message_remove_foreign_coin.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@

func NewMsgRemoveForeignCoin(creator string, name string) *MsgRemoveForeignCoin {
return &MsgRemoveForeignCoin{
Creator: creator,
Name: name,
Creator: creator,
ZRC20Address: name,

Check failure on line 15 in x/fungible/types/message_remove_foreign_coin.go

View workflow job for this annotation

GitHub Actions / smoke-test 

unknown field ZRC20Address in struct literal of type MsgRemoveForeignCoin

Check failure on line 15 in x/fungible/types/message_remove_foreign_coin.go

View workflow job for this annotation

GitHub Actions / lint 

unknown field ZRC20Address in struct literal of type MsgRemoveForeignCoin (typecheck)

Check failure on line 15 in x/fungible/types/message_remove_foreign_coin.go

View workflow job for this annotation

GitHub Actions / lint 

unknown field ZRC20Address in struct literal of type MsgRemoveForeignCoin) (typecheck)

Check failure on line 15 in x/fungible/types/message_remove_foreign_coin.go

View workflow job for this annotation

GitHub Actions / lint 

unknown field ZRC20Address in struct literal of type MsgRemoveForeignCoin) (typecheck)

Check failure on line 15 in x/fungible/types/message_remove_foreign_coin.go

View workflow job for this annotation

GitHub Actions / gosec-cosmos 

unknown field ZRC20Address in struct literal of type MsgRemoveForeignCoin

Check failure on line 15 in x/fungible/types/message_remove_foreign_coin.go

View workflow job for this annotation

GitHub Actions / build-and-test 

unknown field ZRC20Address in struct literal of type MsgRemoveForeignCoin

Check failure on line 15 in x/fungible/types/message_remove_foreign_coin.go

View workflow job for this annotation

GitHub Actions / build-and-test 

unknown field ZRC20Address in struct literal of type MsgRemoveForeignCoin

Check failure on line 15 in x/fungible/types/message_remove_foreign_coin.go

View workflow job for this annotation

GitHub Actions / build-and-test 

unknown field ZRC20Address in struct literal of type MsgRemoveForeignCoin

Check failure on line 15 in x/fungible/types/message_remove_foreign_coin.go

View workflow job for this annotation

GitHub Actions / build-and-test 

unknown field ZRC20Address in struct literal of type MsgRemoveForeignCoin

Check failure on line 15 in x/fungible/types/message_remove_foreign_coin.go

View workflow job for this annotation

GitHub Actions / build-and-test 

unknown field ZRC20Address in struct literal of type MsgRemoveForeignCoin

Check failure on line 15 in x/fungible/types/message_remove_foreign_coin.go

View workflow job for this annotation

GitHub Actions / build-and-test 

unknown field ZRC20Address in struct literal of type MsgRemoveForeignCoin

Check failure on line 15 in x/fungible/types/message_remove_foreign_coin.go

View workflow job for this annotation

GitHub Actions / gosec 

unknown field ZRC20Address in struct literal of type MsgRemoveForeignCoin

Check failure on line 15 in x/fungible/types/message_remove_foreign_coin.go

View workflow job for this annotation

GitHub Actions / lint 

unknown field ZRC20Address in struct literal of type MsgRemoveForeignCoin (typecheck)

Check failure on line 15 in x/fungible/types/message_remove_foreign_coin.go

View workflow job for this annotation

GitHub Actions / lint 

unknown field ZRC20Address in struct literal of type MsgRemoveForeignCoin) (typecheck)

Check failure on line 15 in x/fungible/types/message_remove_foreign_coin.go

View workflow job for this annotation

GitHub Actions / lint 

unknown field ZRC20Address in struct literal of type MsgRemoveForeignCoin) (typecheck)

Check failure on line 15 in x/fungible/types/message_remove_foreign_coin.go

View workflow job for this annotation

GitHub Actions / gosec-cosmos 

unknown field ZRC20Address in struct literal of type MsgRemoveForeignCoin

Check failure on line 15 in x/fungible/types/message_remove_foreign_coin.go

View workflow job for this annotation

GitHub Actions / gosec 

unknown field ZRC20Address in struct literal of type MsgRemoveForeignCoin
}
}
lumtis marked this conversation as resolved.
Show resolved Hide resolved

Expand Down
147 changes: 73 additions & 74 deletions x/fungible/types/tx.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading