Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename MsgRemoveForeignCoin name field into zrc20Address and remove crosschain param #1722

Closed
wants to merge 6 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@

* `zetaclientd start`: now requires 2 inputs from stdin: hotkey password and tss keyshare password
Starting zetaclient now requires two passwords to be input; one for the hotkey and another for the tss key-share.
* `MsgRemoveForeignCoin`: `Name` field has been renamed in to `ZRC20Address`

### Features

Expand Down
3 changes: 0 additions & 3 deletions docs/openapi/openapi.swagger.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -54738,9 +54738,6 @@ definitions:
}
zetacorecrosschainParams:
type: object
properties:
enabled:
type: boolean
description: Params defines the parameters for the module.
zetacorecrosschainQueryGetTssAddressResponse:
type: object
Expand Down
2 changes: 1 addition & 1 deletion docs/spec/fungible/messages.md
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ Authorized: admin policy group 2.
```proto
message MsgRemoveForeignCoin {
string creator = 1;
string name = 2;
string zrc20_address = 2;
}
```

Expand Down
1 change: 0 additions & 1 deletion proto/crosschain/params.proto
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,4 @@ option go_package = "github.com/zeta-chain/zetacore/x/crosschain/types";
// Params defines the parameters for the module.
message Params {
option (gogoproto.goproto_stringer) = false;
bool enabled = 1;
}
2 changes: 1 addition & 1 deletion proto/fungible/tx.proto
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ message MsgDeployFungibleCoinZRC20Response {

message MsgRemoveForeignCoin {
string creator = 1;
string name = 2;
string zrc20_address = 2;
}

message MsgRemoveForeignCoinResponse {}
Expand Down
5 changes: 0 additions & 5 deletions typescript/crosschain/params_pb.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,6 @@ import { Message, proto3 } from "@bufbuild/protobuf";
* @generated from message zetachain.zetacore.crosschain.Params
*/
export declare class Params extends Message<Params> {
/**
* @generated from field: bool enabled = 1;
*/
enabled: boolean;

constructor(data?: PartialMessage<Params>);

static readonly runtime: typeof proto3;
Expand Down
4 changes: 2 additions & 2 deletions typescript/fungible/tx_pb.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -291,9 +291,9 @@ export declare class MsgRemoveForeignCoin extends Message<MsgRemoveForeignCoin>
creator: string;

/**
* @generated from field: string name = 2;
* @generated from field: string zrc20_address = 2;
*/
name: string;
zrc20Address: string;

constructor(data?: PartialMessage<MsgRemoveForeignCoin>);

Expand Down
56 changes: 7 additions & 49 deletions x/crosschain/types/params.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions x/fungible/types/message_remove_foreign_coin.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@

var _ sdk.Msg = &MsgRemoveForeignCoin{}

func NewMsgRemoveForeignCoin(creator string, name string) *MsgRemoveForeignCoin {
func NewMsgRemoveForeignCoin(creator string, zrc20Address string) *MsgRemoveForeignCoin {
return &MsgRemoveForeignCoin{
Creator: creator,
Name: name,
Creator: creator,
ZRC20Address: zrc20Address,

Check failure on line 16 in x/fungible/types/message_remove_foreign_coin.go

View workflow job for this annotation

GitHub Actions / e2e-test

unknown field ZRC20Address in struct literal of type MsgRemoveForeignCoin

Check failure on line 16 in x/fungible/types/message_remove_foreign_coin.go

View workflow job for this annotation

GitHub Actions / gosec

unknown field ZRC20Address in struct literal of type MsgRemoveForeignCoin

Check failure on line 16 in x/fungible/types/message_remove_foreign_coin.go

View workflow job for this annotation

GitHub Actions / build-and-test

unknown field ZRC20Address in struct literal of type MsgRemoveForeignCoin

Check failure on line 16 in x/fungible/types/message_remove_foreign_coin.go

View workflow job for this annotation

GitHub Actions / build-and-test

unknown field ZRC20Address in struct literal of type MsgRemoveForeignCoin

Check failure on line 16 in x/fungible/types/message_remove_foreign_coin.go

View workflow job for this annotation

GitHub Actions / build-and-test

unknown field ZRC20Address in struct literal of type MsgRemoveForeignCoin

Check failure on line 16 in x/fungible/types/message_remove_foreign_coin.go

View workflow job for this annotation

GitHub Actions / build-and-test

unknown field ZRC20Address in struct literal of type MsgRemoveForeignCoin

Check failure on line 16 in x/fungible/types/message_remove_foreign_coin.go

View workflow job for this annotation

GitHub Actions / build-and-test

unknown field ZRC20Address in struct literal of type MsgRemoveForeignCoin

Check failure on line 16 in x/fungible/types/message_remove_foreign_coin.go

View workflow job for this annotation

GitHub Actions / gosec-cosmos

unknown field ZRC20Address in struct literal of type MsgRemoveForeignCoin

Check failure on line 16 in x/fungible/types/message_remove_foreign_coin.go

View workflow job for this annotation

GitHub Actions / lint

unknown field ZRC20Address in struct literal of type MsgRemoveForeignCoin (typecheck)

Check failure on line 16 in x/fungible/types/message_remove_foreign_coin.go

View workflow job for this annotation

GitHub Actions / lint

unknown field ZRC20Address in struct literal of type MsgRemoveForeignCoin) (typecheck)

Check failure on line 16 in x/fungible/types/message_remove_foreign_coin.go

View workflow job for this annotation

GitHub Actions / lint

unknown field ZRC20Address in struct literal of type MsgRemoveForeignCoin) (typecheck)
}
}

Expand Down
Loading
Loading