refactor: rename MsgRemoveForeignCoin name field into zrc20Address and remove crosschain param

[ptdatta]

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Closes: #1650 & #1596

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

• Tested CCTX in localnet
• Tested in development environment
• Go unit tests
• Go integration tests
• Tested via GitHub Actions

Checklist:

• I have added unit tests that prove my fix feature works

[lumtis]

Thanks!

We need to run:

make generate

And could we add this line in changlog.md under # Unreleased

## Unreleased

- `MsgRemoveForeignCoin`: `Name` field has been renamed in to `ZRC20Address`

[ptdatta]

Thanks!

We need to run:

make generate

And could we add this line in changlog.md under # Unreleased

## Unreleased

- `MsgRemoveForeignCoin`: `Name` field has been renamed in to `ZRC20Address`

Oops sorry, I previously ran make proto

[lumtis]

Thanks!
We need to run:

make generate

And could we add this line in changlog.md under # Unreleased

## Unreleased

- `MsgRemoveForeignCoin`: `Name` field has been renamed in to `ZRC20Address`

Oops sorry, I previously ran make proto

Does the command complete successfully?
It openapi file get deleted while it shouldn't happen when running the command

[ptdatta]

Thanks!
We need to run:

make generate

And could we add this line in changlog.md under # Unreleased

## Unreleased

- `MsgRemoveForeignCoin`: `Name` field has been renamed in to `ZRC20Address`

Oops sorry, I previously ran make proto

Does the command complete successfully? It openapi file get deleted while it shouldn't happen when running the command

No, it just deleted some of the files. So, I again cloned the repo again and made changes to it.

[lumtis]

Thanks!
We need to run:

make generate

And could we add this line in changlog.md under # Unreleased

## Unreleased

- `MsgRemoveForeignCoin`: `Name` field has been renamed in to `ZRC20Address`

Oops sorry, I previously ran make proto

Does the command complete successfully? It openapi file get deleted while it shouldn't happen when running the command

No, it just deleted some of the files. So, I again cloned the repo again and made changes to it.

Ok, it seems the swagger file is still deleted in the PR

[ptdatta]

Thanks!
We need to run:

make generate

And could we add this line in changlog.md under # Unreleased

## Unreleased

- `MsgRemoveForeignCoin`: `Name` field has been renamed in to `ZRC20Address`

Oops sorry, I previously ran make proto

Does the command complete successfully? It openapi file get deleted while it shouldn't happen when running the command

No, it just deleted some of the files. So, I again cloned the repo again and made changes to it.

Ok, it seems the swagger file is still deleted in the PR

Sorry, Added it.

[lumtis]

Looks good!

[lumtis]

Looks like there are some build issues @ptdatta

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.68%. Comparing base (589e228) to head (b2004ef).

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #1722      +/-   ##
===========================================
+ Coverage    33.95%   37.68%   +3.72%     
===========================================
  Files          132        5     -127     
  Lines         9253      406    -8847     
===========================================
- Hits          3142      153    -2989     
+ Misses        5886      234    -5652     
+ Partials       225       19     -206     

see 127 files with indirect coverage changes

[lumtis]

Closing as it seems no longer active. Please let us know if you want to take it back. Thanks for the PR.