chore: Next.js Pay-as-you-Go starter kit [SIDE QUEST] #2358
Conversation
unrenamed
requested review from
perkinsjr,
chronark,
mcstepp and
MichaelUnkey
as code owners
|
|
@unrenamed is attempting to deploy a commit to the Unkey Team on Vercel. A member of the Team first needs to authorize it. |
📝 WalkthroughWalkthroughThe pull request updates the document Changes
Assessment against linked issues
Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🧰 Additional context used🔇 Additional comments (3)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Thank you for following the naming conventions for pull request titles! 🙏 |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
oss.gg/7_create_a_template.md (1)
39-39: Fix typo and remove spaces in link textThere's a typo in the word "protection" and there are unnecessary spaces in the link text. Please apply the following changes:
-» 11-October-2024 by Prabin Subedi [Starter template for Unkey Route protecttion in Hono Webframework in Cloudflare workers ](https://github.com/prabincankod/hono-unkey-cflare) +» 11-October-2024 by Prabin Subedi [Starter template for Unkey Route protection in Hono Webframework in Cloudflare workers](https://github.com/prabincankod/hono-unkey-cflare)This will correct the spelling and resolve the Markdownlint warning MD039 (no-space-in-links).
🧰 Tools
🪛 Markdownlint
39-39: null
Spaces inside link text(MD039, no-space-in-links)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- oss.gg/7_create_a_template.md (1 hunks)
🧰 Additional context used
🪛 Markdownlint
oss.gg/7_create_a_template.md
39-39: null
Spaces inside link text(MD039, no-space-in-links)
🔇 Additional comments (2)
oss.gg/7_create_a_template.md (2)
40-40: LGTM! Entry aligns with PR objectivesThis entry correctly follows the required format and introduces the Next.js Unkey Pay-as-you-Go Starter Kit, which aligns perfectly with the PR objectives mentioned earlier. The template demonstrates the implementation of a Pay-as-you-Go system using the Unkey API in a Next.js application.
39-40: Summary: New entries align with PR objectives and side quest goalsThe two new entries added to this file successfully contribute to the collection of templates for using Unkey with various frameworks. These additions align well with the PR objectives and the side quest goals outlined in issue #2150. The templates provide valuable examples for the community, showcasing how to integrate Unkey with different technologies (Hono and Next.js).
To ensure consistency and maintain the high quality of the document, please address the minor issues mentioned in the previous comment for the Hono template entry.
🧰 Tools
🪛 Markdownlint
39-39: null
Spaces inside link text(MD039, no-space-in-links)
|
small nitpick: switch to lightmode and our logo is gone :D could you use this svg? |
|
and can you help me try it out? I just went to the signup page of your hosted example
|
|
@chronark I think this is related to how Supabase auth filters "unauthorized" email domains to prevent spam, bots, etc. This should be configurable, but I haven't checked that yet. It definitely supports |
|
I can try to use a free Resend account as a custom SMTP to to provide additional email capacity for demo testers. Will do that later today. https://resend.com/blog/how-to-configure-supabase-to-send-emails-from-your-domain |
|
don't sweat it, a disclaimer that only gmail works would be fine too I think |
|
update: my gmail doesn't work either, same error |
I'll add a custom SMTP then 😃 |
|
@chronark I've fixed the logo and another bug related to the app themes. As for the custom SMTP, I'm afraid I cannot fix that at the moment. Apparently, Resend does not allow to integrate Supabase using free SMTP services and I don't have a custom domain to register within Resend account. I can remove the links to the demo app deployed to Vercel to not confuse anyone. The starter kit can still be cloned and run locally. |
|
yeah that's probably best. It's a shame, but advertising it when it's not usable would be frustrating |
|
Yeah, this is exactly why I should remove it. My bad, I haven't tested this part thoroughly beforehand. Meanwhile, feel free to test it locally. The screenshot doesn't actually cover the core area of the app 😅 |
|
@chronark I removed all links to the live demo from the code base and repository page. |
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- oss.gg/7_create_a_template.md (1 hunks)
🧰 Additional context used
🪛 Markdownlint
oss.gg/7_create_a_template.md
40-40: null
Spaces inside link text(MD039, no-space-in-links)
🔇 Additional comments (2)
oss.gg/7_create_a_template.md (2)
41-41: LGTM!The entry for the Next.js Unkey Pay-as-you-Go Starter Kit is well-formatted and provides all necessary information.
40-41: Summary of changesThe additions to the template list are well-formatted and provide valuable new resources for developers looking to integrate Unkey with different frameworks. The new entries for Hono Webframework and Next.js Pay-as-you-Go maintain the document's structure and adhere to the specified requirements.
These additions enhance the variety of available templates, potentially attracting more developers to use Unkey in their projects.
🧰 Tools
🪛 Markdownlint
40-40: null
Spaces inside link text(MD039, no-space-in-links)
|
Awarding unrenamed: 750 points 🕹️ Well done! Check out your new contribution on oss.gg/unrenamed |
|
@chronark just noticed 
|
What does this PR do?
Adds a starter kit showcasing how to leverage Unkey API to implement Pay-as-you-Go system in your Next.js app powered by Supabase. https://github.com/unrenamed/unkey-nextjs-pay-as-you-go
Fixes #2150
Summary by CodeRabbit
Summary by CodeRabbit
New Features
Documentation