feat: AdonisJS + Unkey RBAC route protection #2492
Conversation
Ionfinisher
requested review from
perkinsjr,
chronark,
mcstepp and
MichaelUnkey
as code owners
|
|
@Ionfinisher is attempting to deploy a commit to the Unkey Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
📝 WalkthroughWalkthroughThe changes in this pull request introduce a new entry to a project list showcasing the use of Unkey for API protection. Specifically, it adds a contribution by Teddy ASSIH titled "AdonisJS + Unkey RBAC route protection," including relevant details such as the contributor's name, date, and a link to the associated GitHub repository. The overall structure for documenting contributions remains unchanged. Changes
Assessment against linked issues
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Thank you for following the naming conventions for pull request titles! 🙏 |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (1)
oss.gg/7_create_a_template.md (1)
57-57: Fix Markdown lint issue: Remove space inside link text.There's an extra space at the end of the link text. Please remove it to resolve the Markdown lint issue.
Apply this change:
-» 18-October-2024 by Teddy ASSIH [AdonisJS + Unkey RBAC route protection ](https://github.com/Ionfinisher/unkey-adonisjs-template) +» 18-October-2024 by Teddy ASSIH [AdonisJS + Unkey RBAC route protection](https://github.com/Ionfinisher/unkey-adonisjs-template)🧰 Tools
🪛 Markdownlint
57-57: null
Spaces inside link text(MD039, no-space-in-links)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- oss.gg/7_create_a_template.md (1 hunks)
🧰 Additional context used
🪛 Markdownlint
oss.gg/7_create_a_template.md
57-57: null
Spaces inside link text(MD039, no-space-in-links)
| @@ -54,4 +54,6 @@ Your turn 👇 | |||
|
|
|||
| » 12-October-2024 by Nazar Poshtarenko [Next.js Unkey Pay-as-you-Go Starter Kit](https://github.com/unrenamed/unkey-nextjs-pay-as-you-go) | |||
|
|
|||
| » 18-October-2024 by Teddy ASSIH [AdonisJS + Unkey RBAC route protection ](https://github.com/Ionfinisher/unkey-adonisjs-template) | |||
There was a problem hiding this comment.
💡 Codebase verification
Missing MIT License
The repository unkey-adonisjs-template does not include an MIT license, which is required.
🔗 Analysis chain
LGTM! Please verify the repository meets all requirements.
The new entry for the AdonisJS + Unkey RBAC route protection template looks good and follows the correct format. However, please ensure that the linked repository meets all the requirements:
- It must be open source.
- It must be MIT licensed.
- It must have a README.md including a quickstart guide for running the example.
To verify these requirements, you can run the following script:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify repository requirements
# Clone the repository
git clone https://github.com/Ionfinisher/unkey-adonisjs-template.git temp_repo
cd temp_repo
# Check for MIT license
if grep -q "MIT" LICENSE; then
echo "MIT license found"
else
echo "MIT license not found"
fi
# Check for README.md
if [ -f README.md ]; then
echo "README.md found"
# Check for quickstart guide in README.md
if grep -qi "quickstart" README.md; then
echo "Quickstart guide found in README.md"
else
echo "Quickstart guide not found in README.md"
fi
else
echo "README.md not found"
fi
# Clean up
cd ..
rm -rf temp_repo
Length of output: 505
🧰 Tools
🪛 Markdownlint
57-57: null
Spaces inside link text(MD039, no-space-in-links)
|
/award 750 |
|
Awarding Ionfinisher: 750 points 🕹️ Well done! Check out your new contribution on oss.gg/Ionfinisher |
What does this PR do?
Protecting AdonisJS routes with Unkey
Github repo: https://github.com/Ionfinisher/unkey-adonisjs-template
Fixes #2150
Summary by CodeRabbit