-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: React-Native Send Email ratelimiting example with Unkey #2545
chore: React-Native Send Email ratelimiting example with Unkey #2545
Conversation
|
@harshsbhat is attempting to deploy a commit to the Unkey Team on Vercel. A member of the Team first needs to authorize it. |
📝 WalkthroughWalkthroughThe pull request introduces a new entry to the list of projects in the document Changes
Assessment against linked issues
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thank you for following the naming conventions for pull request titles! 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
oss.gg/7_create_a_template.md (1)
57-57
: Fix markdown link formatting.Remove the extra space before the closing bracket in the link text to comply with markdown best practices.
Apply this diff:
-» 23-October-2024 by Harsh Bhat [React-Native Send Email ratelimiting example with Unkey ](https://github.com/harshsbhat/unkey-react-native) +» 23-October-2024 by Harsh Bhat [React-Native Send Email ratelimiting example with Unkey](https://github.com/harshsbhat/unkey-react-native)🧰 Tools
🪛 Markdownlint
57-57: null
Spaces inside link text(MD039, no-space-in-links)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- oss.gg/7_create_a_template.md (1 hunks)
🧰 Additional context used
🪛 Markdownlint
oss.gg/7_create_a_template.md
57-57: null
Spaces inside link text(MD039, no-space-in-links)
🔇 Additional comments (1)
oss.gg/7_create_a_template.md (1)
57-58
: Entry meets all requirements.The contribution:
- ✓ Follows the required format
- ✓ Provides a unique template (React Native integration)
- ✓ Links to a public GitHub repository
Let's verify there are no similar entries:
✅ Verification successful
The initial search shows only one React Native entry, which is the one being reviewed. However, let's do a more thorough verification by checking for any similar email-related templates or entries by Harsh Bhat:
Entry is unique but author has multiple recent contributions
While this React Native email rate-limiting template is unique and doesn't duplicate any existing entries, I notice that the same author (Harsh Bhat) has submitted 4 templates within a 20-day period:
- Flask RBAC (Oct 4)
- Cost Based ratelimiting (Oct 6)
- FastAPI Boilerplate (Oct 10)
- React Native Email (Oct 23)
Let's verify if there are any submission frequency guidelines:
Template contribution is unique and valid
The React Native email rate-limiting template:
- Follows the required format
- Demonstrates a unique use case (React Native + email rate limiting)
- Links to a public GitHub repository
- Does not duplicate any existing entries
While the author has multiple recent contributions, there are no explicit guidelines restricting submission frequency, and each contribution demonstrates integration with different frameworks/use-cases (Flask, FastAPI, React Native) providing value to the community.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check for similar React Native entries # Test: Search for "React-Native" or "react-native" in the file rg -i "react.?native" "oss.gg/7_create_a_template.md"Length of output: 194
Script:
#!/bin/bash # Check for any email-related entries and entries by the same author rg -i "email|harsh" "oss.gg/7_create_a_template.md" # Also check if this repository URL was previously added rg -i "harshsbhat/unkey-react-native" "oss.gg/7_create_a_template.md"Length of output: 768
Script:
#!/bin/bash # Check for any submission guidelines or rules regarding frequency rg -i "guideline|rule|limit|restriction|submission" "oss.gg/7_create_a_template.md"Length of output: 1048
🧰 Tools
🪛 Markdownlint
57-57: null
Spaces inside link text(MD039, no-space-in-links)
/award 750 |
Awarding harshsbhat: 750 points 🕹️ Well done! Check out your new contribution on oss.gg/harshsbhat |
What does this PR do?
Since there are no examples/templates that showcase how Unkey can be integrated with Mobile apps. This example can help solve that. I have rate limited the send email button to showcase
@unkey/ratelimit
for this examplehttps://github.com/harshsbhat/unkey-react-native
Fixes #2150
react-native-unkey.mp4
Summary by CodeRabbit
New Features
Documentation