Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): chat panel render warning #9446

Merged
merged 1 commit into from
Dec 31, 2024
Merged

fix(editor): chat panel render warning #9446

merged 1 commit into from
Dec 31, 2024

Conversation

doodlewind
Copy link
Member

@doodlewind doodlewind commented Dec 31, 2024

Fixed the updated warning of both chat-panel and chat-panel-messages

image

Copy link

graphite-app bot commented Dec 31, 2024

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

Copy link

codecov bot commented Dec 31, 2024

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 51.63%. Comparing base (7c41775) to head (adf14d1).
Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
...suite/presets/ai/chat-panel/chat-panel-messages.ts 0.00% 8 Missing ⚠️
...core/src/blocksuite/presets/ai/chat-panel/index.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #9446      +/-   ##
==========================================
+ Coverage   51.59%   51.63%   +0.04%     
==========================================
  Files        2152     2152              
  Lines       97016    97016              
  Branches    16209    16208       -1     
==========================================
+ Hits        50057    50096      +39     
+ Misses      45613    45567      -46     
- Partials     1346     1353       +7     
Flag Coverage Δ
server-test 78.07% <ø> (ø)
unittest 31.03% <0.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Dec 31, 2024

Merge activity

Fixed the updated warning of both `chat-panel` and `chat-panel-messages`

![image](https://github.com/user-attachments/assets/73f30e45-119a-4899-bf05-84f8f64b944b)
@graphite-app graphite-app bot merged commit adf14d1 into canary Dec 31, 2024
61 checks passed
@graphite-app graphite-app bot deleted the doodl/fix-chat branch December 31, 2024 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants