Skip to content

Commit

Permalink
fix(editor): chat panel render warning (#9446)
Browse files Browse the repository at this point in the history
Fixed the updated warning of both `chat-panel` and `chat-panel-messages`

![image](https://github.com/user-attachments/assets/73f30e45-119a-4899-bf05-84f8f64b944b)
  • Loading branch information
doodlewind committed Dec 31, 2024
1 parent 7c41775 commit adf14d1
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 25 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import {
UnauthorizedError,
} from '@blocksuite/affine/blocks';
import { WithDisposable } from '@blocksuite/affine/global/utils';
import { css, html, nothing, type PropertyValues } from 'lit';
import { css, html, nothing } from 'lit';
import { property, query, state } from 'lit/decorators.js';
import { repeat } from 'lit/directives/repeat.js';
import { styleMap } from 'lit/directives/style-map.js';
Expand Down Expand Up @@ -139,25 +139,6 @@ export class ChatPanelMessages extends WithDisposable(ShadowlessElement) {
@state()
accessor showChatCards = true;

protected override updated(changedProperties: PropertyValues) {
if (changedProperties.has('host')) {
const { disposables } = this;

disposables.add(
this.host.selection.slots.changed.on(() => {
this._selectionValue = this.host.selection.value;
})
);
const docModeService = this.host.std.get(DocModeProvider);
disposables.add(
docModeService.onPrimaryModeChange(
() => this.requestUpdate(),
this.host.doc.id
)
);
}
}

private _renderAIOnboarding() {
return this.isLoading ||
!this.host?.doc.awarenessStore.getFlag('enable_ai_onboarding')
Expand Down Expand Up @@ -284,13 +265,16 @@ export class ChatPanelMessages extends WithDisposable(ShadowlessElement) {

override connectedCallback() {
super.connectedCallback();
const { disposables } = this;
const docModeService = this.host.std.get(DocModeProvider);

Promise.resolve(AIProvider.userInfo)
.then(res => {
this.avatarUrl = res?.avatarUrl ?? '';
})
.catch(console.error);
this.disposables.add(

disposables.add(
AIProvider.slots.userInfo.on(userInfo => {
const { status, error } = this.chatContextValue;
this.avatarUrl = userInfo?.avatarUrl ?? '';
Expand All @@ -303,12 +287,22 @@ export class ChatPanelMessages extends WithDisposable(ShadowlessElement) {
}
})
);

this.disposables.add(
disposables.add(
AIProvider.slots.toggleChatCards.on(({ visible }) => {
this.showChatCards = visible;
})
);
disposables.add(
this.host.selection.slots.changed.on(() => {
this._selectionValue = this.host.selection.value;
})
);
disposables.add(
docModeService.onPrimaryModeChange(
() => this.requestUpdate(),
this.host.doc.id
)
);
}

renderItem(item: ChatItem, isLast: boolean) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -191,8 +191,10 @@ export class ChatPanel extends WithDisposable(ShadowlessElement) {

protected override updated(_changedProperties: PropertyValues) {
if (_changedProperties.has('doc')) {
this.chatContextValue.chatSessionId = null;
this._resetItems();
requestAnimationFrame(() => {
this.chatContextValue.chatSessionId = null;
this._resetItems();
});
}

if (
Expand Down

0 comments on commit adf14d1

Please sign in to comment.