Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): chat panel render warning #9446

Merged
merged 1 commit into from
Dec 31, 2024
Merged

fix(editor): chat panel render warning #9446

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 17 additions & 23 deletions packages/frontend/core/src/blocksuite/presets/ai/chat-panel/chat-panel-messages.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import {
UnauthorizedError,
} from '@blocksuite/affine/blocks';
import { WithDisposable } from '@blocksuite/affine/global/utils';
import { css, html, nothing, type PropertyValues } from 'lit';
import { css, html, nothing } from 'lit';
import { property, query, state } from 'lit/decorators.js';
import { repeat } from 'lit/directives/repeat.js';
import { styleMap } from 'lit/directives/style-map.js';
Expand Down Expand Up @@ -139,25 +139,6 @@ export class ChatPanelMessages extends WithDisposable(ShadowlessElement) {
@state()
accessor showChatCards = true;

protected override updated(changedProperties: PropertyValues) {
if (changedProperties.has('host')) {
const { disposables } = this;

disposables.add(
this.host.selection.slots.changed.on(() => {
this._selectionValue = this.host.selection.value;
})
);
const docModeService = this.host.std.get(DocModeProvider);
disposables.add(
docModeService.onPrimaryModeChange(
() => this.requestUpdate(),
this.host.doc.id
)
);
}
}

private _renderAIOnboarding() {
return this.isLoading ||
!this.host?.doc.awarenessStore.getFlag('enable_ai_onboarding')
Expand Down Expand Up @@ -284,13 +265,16 @@ export class ChatPanelMessages extends WithDisposable(ShadowlessElement) {

override connectedCallback() {
super.connectedCallback();
const { disposables } = this;
const docModeService = this.host.std.get(DocModeProvider);

Promise.resolve(AIProvider.userInfo)
.then(res => {
this.avatarUrl = res?.avatarUrl ?? '';
})
.catch(console.error);
this.disposables.add(

disposables.add(
AIProvider.slots.userInfo.on(userInfo => {
const { status, error } = this.chatContextValue;
this.avatarUrl = userInfo?.avatarUrl ?? '';
Expand All @@ -303,12 +287,22 @@ export class ChatPanelMessages extends WithDisposable(ShadowlessElement) {
}
})
);

this.disposables.add(
disposables.add(
AIProvider.slots.toggleChatCards.on(({ visible }) => {
this.showChatCards = visible;
})
);
disposables.add(
this.host.selection.slots.changed.on(() => {
this._selectionValue = this.host.selection.value;
})
);
disposables.add(
docModeService.onPrimaryModeChange(
() => this.requestUpdate(),
this.host.doc.id
)
);
}

renderItem(item: ChatItem, isLast: boolean) {
Expand Down
6 changes: 4 additions & 2 deletions packages/frontend/core/src/blocksuite/presets/ai/chat-panel/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,8 +191,10 @@ export class ChatPanel extends WithDisposable(ShadowlessElement) {

protected override updated(_changedProperties: PropertyValues) {
if (_changedProperties.has('doc')) {
this.chatContextValue.chatSessionId = null;
this._resetItems();
requestAnimationFrame(() => {
this.chatContextValue.chatSessionId = null;
this._resetItems();
});
}

if (
Expand Down
Loading