Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[on #250 of start-jsk/rtmros_gazebo][hrpsys_gazebo_tutorials] enable samplerobot and hrp2 on kinetic and melodic #568

Merged
merged 6 commits into from
May 15, 2020
Merged

[on #250 of start-jsk/rtmros_gazebo][hrpsys_gazebo_tutorials] enable samplerobot and hrp2 on kinetic and melodic #568

merged 6 commits into from
May 15, 2020

Conversation

Naoki-Hiraoka
Copy link
Contributor

This PR enables hrp2 gazebo simulation on kinetic.
This PR in on start-jsk/rtmros_gazebo#236.

roslaunch hrpsys_gazebo_tutorials gazebo_hrp2jsk_no_controllers.launch
rtmlaunch hrpsys_gazebo_tutorials hrp2jsk_hrpsys_bringup.launch

hrp2jsk

roslaunch hrpsys_gazebo_tutorials gazebo_hrp2jsknt_no_controllers.launch
rtmlaunch hrpsys_gazebo_tutorials hrp2jsknt_hrpsys_bringup.launch

hrp2jsknt

roslaunch hrpsys_gazebo_tutorials gazebo_hrp2jsknts_no_controllers.launch
rtmlaunch hrpsys_gazebo_tutorials hrp2jsknts_hrpsys_bringup.launch

hrp2jsknts

@Naoki-Hiraoka Naoki-Hiraoka changed the title [WIP][on #246 of start-jsk/rtmros_gazebo][hrpsys_gazebo_tutorials] enable hrp2 on kinetic [WIP][on #250 of start-jsk/rtmros_gazebo][hrpsys_gazebo_tutorials] enable hrp2 on kinetic and melodic Apr 12, 2020
@Naoki-Hiraoka
Copy link
Contributor Author

Naoki-Hiraoka commented Apr 12, 2020 •
edited
Loading

hrp2 gazebo simulation worked for melodic.

oslaunch hrpsys_gazebo_tutorials gazebo_hrp2jsknt_no_controllers.launch
rtmlaunch hrpsys_gazebo_tutorials hrp2jsknt_hrpsys_bringup.launch

The video is 10x fast because my PC (ThinkPad T440s) is not so fast and simulation is slow.
video3

@Naoki-Hiraoka Naoki-Hiraoka changed the title [WIP][on #250 of start-jsk/rtmros_gazebo][hrpsys_gazebo_tutorials] enable hrp2 on kinetic and melodic [on #250 of start-jsk/rtmros_gazebo][hrpsys_gazebo_tutorials] enable hrp2 on kinetic and melodic Apr 13, 2020
pazeshun
pazeshun reviewed Apr 13, 2020
View reviewed changes
Copy link
Contributor

@pazeshun pazeshun left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this break indigo?
Can we keep files (yaml, launch) for indigo as renamed file (e.g., XXX_indigo.yaml, XXX_indigo.launch)?

@Naoki-Hiraoka
Copy link
Contributor Author

Does this break indigo?
Can we keep files (yaml, launch) for indigo as renamed file (e.g., XXX_indigo.yaml, XXX_indigo.launch)?

I fixed it.

Since hrpsys_ros_bridge_tutorials/models/xxx.yaml are common among indigo, kinetic and melodic, some dynamics parameters are changed in indigo. This may break indigo, but I think It's not likely to happen. If any error caused by this PR is reported in indigo, I will fix it.

@pazeshun pazeshun self-requested a review April 14, 2020 07:20
@Naoki-Hiraoka Naoki-Hiraoka changed the title [on #250 of start-jsk/rtmros_gazebo][hrpsys_gazebo_tutorials] enable hrp2 on kinetic and melodic [on #250 of start-jsk/rtmros_gazebo][hrpsys_gazebo_tutorials] enable samplerobot and hrp2 on kinetic and melodic Apr 16, 2020
@Naoki-Hiraoka
Copy link
Contributor Author 

roslaunch hrpsys_gazebo_tutorials gazebo_samplerobot_no_controllers.launch
rtmlaunch hrpsys_gazebo_tutorials samplerobot_hrpsys_bringup.launch

samplerobot

pazeshun
pazeshun requested changes May 4, 2020
View reviewed changes
README.md Show resolved Hide resolved
@k-okada k-okada mentioned this pull request May 5, 2020
Open
@Naoki-Hiraoka Naoki-Hiraoka mentioned this pull request May 7, 2020
Closed
pazeshun
pazeshun requested changes May 12, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
@Naoki-Hiraoka
[hrpsys_g
cf9ba0b 
azebo_tutorials]add HRPSYS_RATE
@pazeshun pazeshun mentioned this pull request May 12, 2020
Merged
pazeshun
pazeshun approved these changes May 12, 2020
View reviewed changes
Copy link
Contributor

@pazeshun pazeshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant work!!!

@pazeshun
Copy link
Contributor

@k-okada Could you review this?

@Naoki-Hiraoka Naoki-Hiraoka mentioned this pull request May 14, 2020
Closed
@k-okada k-okada merged commit 72b83cd into start-jsk:master May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pazeshun pazeshun pazeshun approved these changes

Assignees
No one assigned
Labels
question
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Naoki-Hiraoka @pazeshun @k-okada