Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Y24-320 - modify sample sheet behaviour so that Revio sample sheets behave as untagged when the behaviour is set to hidden #1442

Conversation

stevieing
Copy link
Collaborator

Closes #

Changes proposed in this pull request

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.97%. Comparing base (421002b) to head (c4421a3).
Report is 30 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1442      +/-   ##
===========================================
+ Coverage    97.93%   97.97%   +0.03%     
===========================================
  Files          422      422              
  Lines        13145    13354     +209     
===========================================
+ Hits         12874    13083     +209     
  Misses         271      271              
Flag Coverage Δ
97.97% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@BenTopping BenTopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is probably fine but it does mean tagged? is no longer just whether the aliquot has a tag or not which might be confusing.

I haven't really looked into this so ignore if irrelevant but could you do something in the sample sheet aliquot concern

@stevieing
Copy link
Collaborator Author

I think this is probably fine but it does mean tagged? is no longer just whether the aliquot has a tag or not which might be confusing.

I haven't really looked into this so ignore if irrelevant but could you do something in the sample sheet aliquot concern

I had a look. There is a lot of indirection and obfuscation so there were a few different methods which led to checking whether there is a tag and I couldn't quite work it out. I have created a story #1443 to refactor it.

@stevieing stevieing merged commit d26c82b into develop Sep 30, 2024
6 checks passed
@stevieing stevieing deleted the 1434-y24-320---bug-for-the-new-pimms_truseq_adapters_v1-libraries-or-pools-should-be-treated-as-untagged-but-the-the-hidden-sample-sheet-bheviour-is-not-working-as-expected-for-the-new-style-sample-sheets branch December 13, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants