Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Y24-320 - [BUG] For the new PiMmS_TruSeq_adapters_v1 libraries or pools should be treated as untagged but the the hidden sample sheet bheviour is not working as expected for the new style sample sheets #1434

Closed
stevieing opened this issue Sep 13, 2024 · 3 comments · Fixed by #1442
Assignees
Labels
Bug Something isn't working SMRT Link SMRT Link Value: 3 Value to the insitute is average

Comments

@stevieing
Copy link
Collaborator

Describe the bug

Thanks for making Live in production. In my haste, I've just realised that I performed UAT as if it is a normal Tag set. Previously, we had the functionality with the TruSeq_CD_i7_i5 tag group that if selected the libraries or pools would be treated as if they are untagged, the biosample name would be a concatenation of all the samples in the pool - the customer deplexes these samples as the tags are asymmetric so unsupported in TRACTION. I think this may have 'broken' with the new csv format. Runs containing libraries with the TruSeq tag group now export a csv file that contains tagged libraries rather than treating them as untagged. The new PiMmS tag set should be treated the same way. I suspect that this is not a quick fix and I have some libraries to load using this tag group. However, I can manually edit the csv file to replicate the previous functionality for the 'Bio Sample Name' row so I can get the libraries sequenced (assuming this is not going to cause any major problems).
RT Ticket Number
If applicable

To Reproduce
Steps to reproduce the behaviour:

  1. Go to page '...'
  2. Click on button '...'
  3. See error

Expected behaviour
What was expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • Windows or Mac?
  • Browser Chrome, Firefox, Safari or other?
  • Browser version (use 'About' to look up)?

Additional context
Add any other context about the problem here.

@stevieing stevieing added Value: 3 Value to the insitute is average SMRT Link SMRT Link Bug Something isn't working labels Sep 13, 2024
@psd-issuer psd-issuer bot changed the title [BUG] For the new PiMmS_TruSeq_adapters_v1 libraries or pools should be treated as untagged but the the hidden sample sheet bheviour is not working as expected for the new style sample sheets Y24-320 - [BUG] For the new PiMmS_TruSeq_adapters_v1 libraries or pools should be treated as untagged but the the hidden sample sheet bheviour is not working as expected for the new style sample sheets Sep 13, 2024
@stevieing stevieing transferred this issue from sanger/traction-ui Sep 19, 2024
@stevieing stevieing self-assigned this Sep 19, 2024
@stevieing
Copy link
Collaborator Author

Incorrect sample sheet:
TRACTION-RUN-1504.csv

Correct sample sheet:
TRACTION-RUN-1504-edit.csv

@stevieing
Copy link
Collaborator Author

stevieing commented Sep 24, 2024

Investigation:

In summary:

  • when the sample sheet behaviour is set to hidden the behaviour is correct for Sequel IIe.
  • when sample behaviour is set to hidden the behaviour is correct for Sequel IIe.

@stevieing
Copy link
Collaborator Author

I have created a new story to refactor the code to make it easier to maintain #1443

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working SMRT Link SMRT Link Value: 3 Value to the insitute is average
Projects
None yet
1 participant