-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merging develop to master - v7.13.1 #1449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-to-add-detailed-documentation-for-smrt-link-versioning-to-inform-other-projects-and-users
…e-to-add-detailed-documentation-for-smrt-link-versioning-to-inform-other-projects-and-users
Fix yard warnings. Minor modifications for SMRT Link related libraries docs.
Update rubocop-rspec 3.0.4 → 3.0.5 (patch)
…mments. Remove output from workflow rake task tests.
…would-like-to-add-detailed-documentation-for-smrt-link-versioning-to-inform-other-projects-and-users Y24-238 - Update SMRT Link Versioning documentation
…ame' instead of 'sample id'
🚨 [security] Update puma 6.4.2 → 6.4.3 (patch)
Y24 318 modify message send to warehouse so that the id_sample_lims will be the sample name
…sample-name" This reverts commit b18f585.
…e_lims will be the sample name"
…ge-sample-name Revert "Y24 318 modify message send to warehouse so that the id_sample_lims will be the sample name"
…fu/update/rubocop-rails-2.26.2
Update rubocop-rails 2.26.1 → 2.26.2 (patch)
🚨 [security] Update webrick 1.8.1 → 1.8.2 (patch)
Remove sequencing_kit_box_barcode from pacbio_runs.
…ed-to-remove-unneeded-tables-and-columns-to-reduce-need-for-maintaining-them-and-removing-them-from-the-data-model Y24-296 - Remove unneeded tables and columns
…imms_truseq_adapters_v1-libraries-or-pools-should-be-treated-as-untagged-but-the-the-hidden-sample-sheet-bheviour-is-not-working-as-expected-for-the-new-style-sample-sheets Y24-320 - modify sample sheet behaviour so that Revio sample sheets behave as untagged when the behaviour is set to hidden
…-with-sample-name Y24-318 modify warehouse message with sample name
…ample-sheet-behaviour Fixed issue with incorrect use of hidden for sample sheet behaviour.
BenTopping
approved these changes
Oct 7, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1449 +/- ##
=======================================
Coverage 97.93% 97.93%
=======================================
Files 422 422
Lines 13145 13148 +3
=======================================
+ Hits 12874 12877 +3
Misses 271 271 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
Changes proposed in this pull request
Instructions for Reviewers
[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to
main
]- Check story numbers included
- Check for debug code
- Check version