Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipes #91

Merged
merged 16 commits into from
Jun 11, 2024
Merged

Pipes #91

merged 16 commits into from
Jun 11, 2024

Conversation

muffato
Copy link
Member

@muffato muffato commented Jun 6, 2024

Closes #76 and #78

First steps towards 1.3.0. In this pull-request, I implemented these:

  • Combined steps to improve the efficiency of the pipeline, especially on large genomes
  • "crumble" is now run on every data type, not just PacBio

Before release, we'll need to make crumble optional and give users a choice of BAM/CRAM (#64). That'll be in another pull-request.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@muffato muffato added the enhancement Improvement of the existing features label Jun 6, 2024
@muffato muffato self-assigned this Jun 6, 2024
@muffato muffato added this to the 1.3.0 milestone Jun 6, 2024
@muffato muffato marked this pull request as draft June 6, 2024 14:58
@muffato muffato changed the base branch from dev to bam_output_tmp June 6, 2024 14:58
@muffato muffato changed the base branch from bam_output_tmp to dev June 6, 2024 14:59
@muffato muffato marked this pull request as ready for review June 6, 2024 14:59
@muffato muffato requested a review from BethYates June 7, 2024 08:52
CHANGELOG.md Show resolved Hide resolved
@muffato
Copy link
Member Author

muffato commented Jun 11, 2024

Regarding the title of 3d71db7 : that was the latest nf-core version at the time. There's now an even more recent version. But what actually mattered was the introduction of meta2 attached to the reference genome, which we can now use in conf/modules.config

@muffato muffato merged commit c5c53eb into dev Jun 11, 2024
6 checks passed
@muffato muffato deleted the pipes branch June 11, 2024 09:11
@muffato muffato mentioned this pull request Jun 24, 2024
9 tasks
@muffato muffato linked an issue Aug 22, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of the existing features
Projects
None yet
2 participants