Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed unneeded patch #94

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Removed unneeded patch #94

merged 1 commit into from
Jun 25, 2024

Conversation

muffato
Copy link
Member

@muffato muffato commented Jun 24, 2024 •
edited by tkchafin
Loading

The patch is not needed anymore since I have combined this module with SAMTOOLS_FASTQ into SAMTOOLS_FILTERTOFASTQ in #91 (diff).

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@muffato
The patch is not needed anymore since I have combined this module wit…
bb7e6be 
…h SAMTOOLS_FASTQ into SAMTOOLS_FILTERTOFASTQ
@muffato muffato added the maintain Tasks to keep pipelines up to date label Jun 24, 2024
@muffato muffato self-assigned this Jun 24, 2024
@muffato muffato requested a review from tkchafin June 25, 2024 08:49
tkchafin
tkchafin approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@tkchafin tkchafin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues identified, verified test suite pass

@muffato muffato merged commit f9be6aa into dev Jun 25, 2024
6 checks passed
@muffato muffato deleted the samtools_view branch June 25, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkchafin tkchafin tkchafin approved these changes

Assignees

@muffato muffato

Labels
maintain Tasks to keep pipelines up to date
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@muffato @tkchafin