Localize add-on & add features for menu display

[rugk]

Supersedes #5

I reverted some of the last commits (i.e. did not use them in this branch) and cleaned up the code afterwards.

See the commits for for information.

BTW here is a code snipping one can paste into the debug console to get the transformed entries of the translated versions of the transformation names:

fonts = await import("/common/modules/data/Fonts.js");
UnicodeTransformationHandler = await import("/common/modules/UnicodeTransformationHandler.js");
fonts.menuStructure.filter(x => x !== fonts.SEPARATOR_ID).map(id => {
	const translatedMenuText = browser.i18n.getMessage(id);
  return UnicodeTransformationHandler.transformText(translatedMenuText, id);
})

We may document that in the wiki or so. It helped me to update the German version, because it names some examples in the docu, this way, they are easy to get.

---

I'm sorry to make such a big PR, but I exaggerated a little as I just implemented two new features too:

• you can show the description of the transformation without the applied transformation (as it may be hardly readable)
• you can show the selected text itself as a "live preview" instead of a static string for each entry 🙂
• you can combine these two

[todo]

check Chrome/ium comaptibility here (this workaround should make it work for now)

unicodify/src/background/modules/ContextMenu.js

Lines 156 to 161 in 6466b50

	// TODO: check Chrome/ium comaptibility here (this workaround should make it work for now)
	if (menus.onShown) {
	menus.onShown.addListener(handleMenuShown);
	}
	menus.onClicked.addListener(handleMenuChoosen);

---

This comment was generated by todo based on a TODO comment in 6466b50 in #17. cc @rugk.

[rugk]

Oh thanks TODO bot, yeah, @tdulcet you’ve tried that with Chromium. I guess for now it’s okay, if it works without errors. (Likely the second feature won’t be possible to be made to work, because Chrome/ium has no browser.menu.onShown callback (API).

[rugk]

FYI

[tdulcet]

I'm sorry to make such a big PR, but I exaggerated a little as I just implemented two new features too:

• you can show the description of the transformation without the applied transformation (as it may be hardly readable)
• you can show the selected text itself as a "live preview" instead of a static string for each entry 🙂
• you can combine these two

Wow, thank you for adding these features! The "live preview" feature is cool.

Oh thanks TODO bot, yeah, @tdulcet you’ve tried that with Chromium. I guess for now it’s okay, if it works without errors. (Likely the second feature won’t be possible to be made to work, because Chrome/ium has no browser.menu.onShown callback (API).

I just tested this PR in Chrome and it does work without errors. You do need to temporally remove the icons from the manifest.json file to load it, as unlike Firefox, Chrome does not let users load extensions if any of the files do not exist. You also have to manually set the settings in the common/modules/data/DefaultSettings.js file until rugk/awesome-emoji-picker#4 (comment) is fixed (or make the change noted in that comment).

Overall, this PR looks very good! I only found a few minor issues. There are also some ESLint errors, which I did not mention in my review, including several additional ones after fixing this.

[tdulcet]

Maybe add a note that this is only for Firefox/Thunderbird.

[rugk]

Yeah, I'd rather think of conditionally disabling it like the isMobile/ MobileHelper (or how it was called) does.
However, I did not want to put work into it yet, but it's definitively a thing that should be done before a Chrome/ium release.

[rugk]

Okay, for now I've adjusted the AutomaticSettings to just handle it the same as mobile-incompatible settings and hide them. May be changed later though.

[tdulcet]

Thanks for updating your library. Note that the change will hide the option for Thunderbird, in addition to Chrome. This line:
https://github.com/TinyWebEx/AutomaticSettings/blob/f67aef00fed936456f009f29a7518d6b38056c78/EnvironmentalOptions.js#L36
would need to be:

return browserInfo.name === "Firefox" || browserInfo.name === "Thunderbird";

although maybe also rename the function to something like isMozilla or isGecko.

[rugk]

Should be fixed now, though I used the vendor name…

[tdulcet]

The vendor name does not work on Thunderbird, since it is blank:

We should either submit a bug to them or change your library to use the name instead.

[tdulcet]

Look good to me! Thanks again for doing this.

[tdulcet]

Looks good to me! Feel free to merge this whenever you are ready.