feat: add performance limit

rugk · Feb 28, 2021 · 6466b50 · 6466b50
1 parent 8f59b28
commit 6466b50
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/src/background/modules/ContextMenu.js b/src/background/modules/ContextMenu.js
@@ -7,6 +7,7 @@ import { COMMUNICATION_MESSAGE_TYPE } from "/common/modules/data/BrowserCommunic
 import { menuStructure, SEPARATOR_ID, TRANSFORMATION_TYPE } from "/common/modules/data/Fonts.js";
 
 const menus = browser.menus || browser.contextMenus; // fallback for Thunderbird
+const PREVIEW_STRING_CUT_LENGTH = 1000; // a setting that may improve performance by not calculating invisible parts of the context menu
 
 let lastCachedUnicodeFontSettings = null;
 
@@ -51,6 +52,11 @@ async function handleMenuShown(info) {
         await menus.removeAll();
         return menus.refresh();
     }
+    // shorten preview text as it may not be shown anyway
+    if (text.length > PREVIEW_STRING_CUT_LENGTH) {
+        // to be sure, we append … anyway, in case some strange OS has a tooltip for context menus or so
+        text = `${text.substr(0, PREVIEW_STRING_CUT_LENGTH)}…`;
+    }
     text = text.normalize();
 
     const menuIsShown = info.menuIds.length > 0;
@@ -156,9 +162,7 @@ export async function init() {
     BrowserCommunication.addListener(COMMUNICATION_MESSAGE_TYPE.UNICODE_FONT, async (request) => {
         lastCachedUnicodeFontSettings = request.optionValue;
 
-        if (!refreshMenu) {
-            await menus.removeAll();
-        }
+        await menus.removeAll();
         return buildMenu(request.optionValue);
     });
 }