Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS class .mozilla-only does not work with Thunderbird #11

Closed
tdulcet opened this issue Mar 30, 2021 · 2 comments
Closed

CSS class .mozilla-only does not work with Thunderbird #11

tdulcet opened this issue Mar 30, 2021 · 2 comments
Labels
blocked Issue cannot be resolved yet as it is blocked by influence things of the project. bug Something isn't working

Comments

@tdulcet
Copy link

tdulcet commented Mar 30, 2021

This line does not work in Thunderbird:

return browserInfo.vendor === "Mozilla";

since the vendor name is blank:
image

I tested it with both Thunderbird 78.9 ESR and 88 Beta. We should either submit a bug to them on BMO or change that line to use the name instead.

This is currently blocking Thunderbird support for Unicodify, although context menu support is also blocked by bug 1656506.

Originally posted in rugk/unicodify#17 (comment).

@rugk rugk added the bug Something isn't working label Apr 1, 2021
@rugk
Copy link
Member

rugk commented Apr 1, 2021

Oh nooo… uhm…

We should either submit a bug to them on BMO or change that line to use the name instead.

We should definitively submit a bug, given it clearly is a bug…

However, if you'd need it, I'd be fine with a workaround like this:

// Thunderbird is explicitly checked as a workaround as Thunderbird does not return the vendor correctly <bug link>
return browserInfo.vendor === "Mozilla" || browserInfo.name === "Thunderbird"; 

@rugk rugk added the blocked Issue cannot be resolved yet as it is blocked by influence things of the project. label Apr 1, 2021
@tdulcet
Copy link
Author

tdulcet commented Apr 2, 2021

We should definitively submit a bug, given it clearly is a bug…

OK, I just created bug 1702722. Note that the getBrowserInfo() function is currently only available in Firefox/Thunderbird, so both the isMozilla() and isFirefox() functions will fail in Chrome.

However, if you'd need it, I'd be fine with a workaround like this

OK, that should work for Unicodify in the meantime...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Issue cannot be resolved yet as it is blocked by influence things of the project. bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants