-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
46 seeding estimator #60
Conversation
These parameters are not used in this commit, only saved.
You can now override the calibration for GPS and baro with whatever value is in the parameters. The parameters are update on every calibration that does occur. This means that in flight you can immeadiatley restart as long as the seed_estimator flag is passed to the launch or run command.
So essentially if the estimator crashes, your you need to restart it you can simply do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this work with symlink-ed parameter files?
It does! Actually it may only work for symlink files... |
To be fair, I think we should transition to have everyone by default use symlink installation. It is better in every way (I think). @JMoore5353 @bsutherland333 is this a bad idea? |
It also works without it being symlinked installed (I just tested it). However, you won't see the saved parameters in the rosflight_ws. You have to go to the share folder to find the actual param file that gets loaded.
|
Something we also want to keep in mind is if we ever publish binaries of ROSplane, then I don't think they'll be installing the source files at all, only the install folder. So if it doesn't work on a non-symlink build, then that would be a problem. |
I hadn't even thought of the binaries. I think we should start testing ROSplane for that soonish. Any Idea on how that is done typically @bsutherland333? |
Since it does work for non-symlinked files, we should be fine correct? Obviously we will have to check, but it should, right? |
The estimator now saves the calibration of each of the initialization for lat, lon, alt and baro reading in the parameters file. You can now pass an argument to the estimator node individually or the launch file as a whole, that will allow you to boot using the saved initialization rather than calibrating again.