feat: skip invisible row for chunk::get_hash_values #15696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fuyufjh
reviewed
Mar 15, 2024
stdrc
reviewed
Mar 15, 2024
fuyufjh
approved these changes
Mar 18, 2024
| for i in self.visibility().iter_ones() { | ||
| // SAFETY(value_at_unchecked): the idx is always in bound. | ||
| unsafe { | ||
| if let Some(scalar) = col.value_at_unchecked(i) { |
There was a problem hiding this comment.
Want to make sure there is no branch instruction?
There was a problem hiding this comment.
yes, and iter_ones() optimize traversing bitmap with bit operator.
There was a problem hiding this comment.
I am afraid iter_ones() is still too heavy (see BitmapOnesIter). That's why I proposed #15696 (comment)
|
A few alternative approaches to make it more "vectorized" which I think worth taking a try:
|
This was referenced Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
link #14985 #15251
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.