Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

investigate: any faster ways of get_hash_values #15731

Open
fuyufjh opened this issue Mar 18, 2024 · 1 comment
Open

investigate: any faster ways of get_hash_values #15731

fuyufjh opened this issue Mar 18, 2024 · 1 comment
Assignees
Milestone

Comments

@fuyufjh
Copy link
Member

fuyufjh commented Mar 18, 2024

A few alternative approaches to make it more "vectorized" which I think worth taking a try:

  1. Replace visibility Bitmap with visibility Vec<usize>. This is because for idx in vec is more vectorized i.e. no branches at all so more friendly to CPU pipeline.
  2. Similar to 1 but only do it for low-selectivity cases
  3. Do compaction before exchange, because we know exchange will always produce low-selectivity results.

Originally posted by @fuyufjh in #15696 (comment)

Copy link
Contributor

This issue has been open for 60 days with no activity. Could you please update the status? Feel free to continue discussion or close as not planned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants