Available CRDs check feature #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rewantsoni
force-pushed
the
avail-crd
branch
4 times, most recently
from
a73fdc2 to
ad84d42
Compare
|
/lgtm |
leelavg
reviewed
Oct 8, 2024
Reasons for this enhancement: - A controller cannot set up a watch for a CRD that is not installed on the cluster, trying to set up a watch will panic the operator - There is no known way, that we are aware of, to add a watch later without client cache issue How does the enhancement work around the issue: - On start of the operator(main), detect which CRDs are avail - At the start each reconcile of controller, we fetch the CRD of interest and compare it with CRDs fetched in previous step, If there is any change, we panic the op Signed-off-by: Rewant Soni <[email protected]> Signed-off-by: raaizik <[email protected]>
Adds a script that bypasses pod restarts Signed-off-by: Rewant Soni <[email protected]> Signed-off-by: raaizik <[email protected]>
No, I don't plan to send a PR to use this for storageCluster CR |
leelavg
approved these changes
Oct 8, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leelavg, raaizik, rewantsoni The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 7e5e1c9
into
red-hat-storage:main
11 of 12 checks passed
rchikatw
pushed a commit
to rchikatw/ocs-client-operator
that referenced
this pull request
Oct 16, 2024
Available CRDs check feature Signed-off-by: rchikatw <[email protected]>
rchikatw
pushed a commit
to rchikatw/ocs-client-operator
that referenced
this pull request
Oct 16, 2024
Available CRDs check feature Signed-off-by: rchikatw <[email protected]>
rchikatw
pushed a commit
to rchikatw/ocs-client-operator
that referenced
this pull request
Oct 16, 2024
Available CRDs check feature Signed-off-by: rchikatw <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
In the future we will need to watch Maintenance Mode CRD by ramen as well
This PR just adds the base for watching the DRClusterConfig CRD by ramen, the actual creation will be added in #177
Ref: red-hat-storage/ocs-operator#2745