controllers: fix available crd #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Testing: |
|
rewantsoni
force-pushed
the
dockerfile
branch
from
babfd4d to
ae28c53
Compare
rewantsoni
force-pushed
the
dockerfile
branch
from
ae28c53 to
401b166
Compare
rewantsoni
changed the title
The PR does the following 1. gcr.io/distroless/static:nonroot does not allow us to run bash scripts, since with available crd we are capturing the exit via a bash script, moving to use registry.access.redhat.com/ubi9/ubi-minimal as the base 2. remove caching only storageCluster crd 3. fix panic while logging Signed-off-by: Rewant Soni <[email protected]>
rewantsoni
force-pushed
the
dockerfile
branch
from
401b166 to
a580d05
Compare
|
Testing - |
Yes, I checked it for any other exitcode/panic it restarts the container. For the restart exit code it restarts the manager |
leelavg
reviewed
Oct 14, 2024
Comment on lines
-117
to
-120
| &extv1.CustomResourceDefinition{}: { | ||
| // only cache storagecluster crd | ||
| Field: storageclustersSelector, | ||
| }, |
There was a problem hiding this comment.
I understand this removal, was a corresponding watch added on this?
There was a problem hiding this comment.
From what I recall, this is used when we deploy CSI and it will be removed in 4.18. Do we need a watch on this?
There was a problem hiding this comment.
Until we remove that we need this, is it effecting your feature?
There was a problem hiding this comment.
Yes, if we specify the CRD to cache here, the operator will only be caching that particular CRD and we cannot have multiple resource names in the field Selector.
If needed, I can add StorageCluster CRD to how we are watching the CRD (with avail CRD feature). WDYT?
There was a problem hiding this comment.
Ack, that can be separate PR, when we get RC I'll be cleaning up lot of code, waiting for that.
leelavg
approved these changes
Oct 14, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leelavg, rewantsoni The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 7d67155
into
red-hat-storage:main
9 of 10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR does the following
bash scripts, since with available crd we are capturing the exit
via a bash script, moving to use
registry.access.redhat.com/ubi9/ubi-minimal as the base