Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

controllers: new controller for maintenance mode #264

Merged
merged 1 commit into from
Nov 25, 2024
Merged

controllers: new controller for maintenance mode #264

merged 1 commit into from
Nov 25, 2024

Conversation

rewantsoni
Copy link
Member

@rewantsoni rewantsoni commented Nov 4, 2024 •
edited
Loading

Depends on red-hat-storage/ocs-operator#2870

A controller which will watch the StorageClient and MaintenanceMode CR by ramen to send a RequestMaintenaneMode RPC call to provider and set the status from response received from GetStorageConfig

@rewantsoni rewantsoni force-pushed the mmode branch 2 times, most recently from 3a4d555 to 79d16fe Compare November 7, 2024 08:00
@rewantsoni rewantsoni force-pushed the mmode branch 3 times, most recently from a71be92 to 91c6229 Compare November 20, 2024 12:25
@rewantsoni rewantsoni marked this pull request as ready for review November 20, 2024 12:30
@github-actions GitHub Actions
Copy link

This PR/issue depends on:

@rewantsoni rewantsoni force-pushed the mmode branch 7 times, most recently from 1085795 to 566c14d Compare November 21, 2024 05:57
nb-ohad
nb-ohad requested changes Nov 21, 2024
View reviewed changes
api/v1alpha1/storageclient_types.go Outdated Show resolved Hide resolved
cmd/main.go Show resolved Hide resolved
internal/controller/maintenancemode_controller.go Outdated Show resolved Hide resolved
internal/controller/maintenancemode_controller.go Outdated Show resolved Hide resolved
internal/controller/maintenancemode_controller.go Outdated Show resolved Hide resolved
internal/controller/maintenancemode_controller.go Outdated Show resolved Hide resolved
internal/controller/maintenancemode_controller.go Outdated Show resolved Hide resolved
@rewantsoni rewantsoni force-pushed the mmode branch 2 times, most recently from 30c26d7 to f7462ff Compare November 21, 2024 09:53
@rewantsoni rewantsoni force-pushed the mmode branch 2 times, most recently from e3b4886 to 0bd54cd Compare November 22, 2024 08:23
nb-ohad
nb-ohad requested changes Nov 22, 2024
View reviewed changes
internal/controller/maintenancemode_controller.go Outdated Show resolved Hide resolved
internal/controller/maintenancemode_controller.go Outdated Show resolved Hide resolved
internal/controller/maintenancemode_controller.go Outdated Show resolved Hide resolved
internal/controller/maintenancemode_controller.go Outdated Show resolved Hide resolved
internal/controller/storageclient_controller.go Outdated Show resolved Hide resolved
internal/controller/maintenancemode_controller.go Outdated Show resolved Hide resolved
internal/controller/maintenancemode_controller.go Outdated Show resolved Hide resolved
internal/controller/maintenancemode_controller.go Outdated Show resolved Hide resolved
internal/controller/maintenancemode_controller.go Outdated Show resolved Hide resolved
internal/controller/maintenancemode_controller.go Outdated Show resolved Hide resolved
@rewantsoni rewantsoni force-pushed the mmode branch 3 times, most recently from 5d92ce7 to 50f1358 Compare November 25, 2024 08:11
nb-ohad
nb-ohad requested changes Nov 25, 2024
View reviewed changes
internal/controller/maintenancemode_controller.go Outdated Show resolved Hide resolved
internal/controller/maintenancemode_controller.go Outdated Show resolved Hide resolved
internal/controller/maintenancemode_controller.go Outdated Show resolved Hide resolved
internal/controller/maintenancemode_controller.go Outdated Show resolved Hide resolved
internal/controller/maintenancemode_controller.go Outdated Show resolved Hide resolved
internal/controller/maintenancemode_controller.go Outdated Show resolved Hide resolved
internal/controller/maintenancemode_controller.go Outdated Show resolved Hide resolved
internal/controller/maintenancemode_controller.go Outdated Show resolved Hide resolved
internal/controller/maintenancemode_controller.go Outdated Show resolved Hide resolved
internal/controller/maintenancemode_controller.go Outdated Show resolved Hide resolved
@rewantsoni rewantsoni force-pushed the mmode branch 3 times, most recently from 002d7e5 to 2873c77 Compare November 25, 2024 09:37
@rewantsoni rewantsoni force-pushed the mmode branch 7 times, most recently from 71b34b2 to 29dd3e4 Compare November 25, 2024 10:53
@nb-ohad
Copy link
Contributor

nb-ohad commented Nov 25, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 25, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nb-ohad, rewantsoni

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 672e703 into red-hat-storage:main Nov 25, 2024
10 checks passed
@rewantsoni
Copy link
Member Author

/jira backport release-4.18

@openshift-ci-robot
Copy link

@rewantsoni: The following backport issues have been created:

Queuing cherrypicks to the requested branches to be created after this PR merges:
/cherrypick release-4.18

In response to this:

/jira backport release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-cherrypick-robot
Copy link

@openshift-ci-robot: new pull request created: #280

In response to this:

@rewantsoni: The following backport issues have been created:

Queuing cherrypicks to the requested branches to be created after this PR merges:
/cherrypick release-4.18

In response to this:

/jira backport release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nb-ohad nb-ohad nb-ohad requested changes

Assignees

@nb-ohad nb-ohad

Labels
approved lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rewantsoni @nb-ohad @openshift-ci-robot @openshift-cherrypick-robot @openshift-merge-robot