PMM-4879 Added defaults file. #863
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
BupycHuk
approved these changes
Apr 20, 2022
BupycHuk
reviewed
Apr 20, 2022
api/managementpb/mysql.proto
Outdated
| @@ -95,6 +95,8 @@ message AddMySQLRequest { | |||
| repeated string disable_collectors = 24; | |||
| // Custom password for exporter endpoint /metrics. | |||
| string agent_password = 28; | |||
| // Path to .cnf file which contains user-name and password | |||
| string defaults_file = 29; | |||
There was a problem hiding this comment.
username is still required field, so we should make it optional and include validation logic into pmm-managed
BupycHuk
requested changes
Apr 20, 2022
api/agentpb/agent.proto
Outdated
| string password = 3; | ||
| string host = 4; | ||
| uint32 port = 5; | ||
|
|
There was a problem hiding this comment.
my.cnf might contain path to socket, so we should return it too
BupycHuk
previously approved these changes
Apr 21, 2022
ritbl
previously approved these changes
May 2, 2022
|
Im going to create PR from non-forked repository. |
artemgavrilov
pushed a commit
that referenced
this pull request
Jun 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMM-4879
Build: SUBMODULES-2465