Skip to content
This repository has been archived by the owner on Jun 21, 2022. It is now read-only.

PMM-4879 Adding support for defaults-file in new mysql service. #1103

Closed
wants to merge 19 commits into from

Conversation

pkadej
Copy link
Contributor

@pkadej pkadej commented May 3, 2022

PMM-4879

Build: SUBMODULES-2465

Build will fail because I cannot use forked version of api (pmm) as dependency in mod.go. To acomplish this, api needs be merged and version of pmm api should be bumped.

@codecov
Copy link

codecov bot commented May 3, 2022

Codecov Report

Merging #1103 (63e1f24) into main (1dded39) will increase coverage by 0.28%.
The diff coverage is 42.62%.

❗ Current head 63e1f24 differs from pull request most recent head f0d0326. Consider uploading reports for the commit f0d0326 to get more accurate results

@@            Coverage Diff             @@
##             main    #1103      +/-   ##
==========================================
+ Coverage   48.73%   49.02%   +0.28%     
==========================================
  Files         180      181       +1     
  Lines       21134    21193      +59     
==========================================
+ Hits        10299    10389      +90     
+ Misses       9697     9649      -48     
- Partials     1138     1155      +17     
Flag Coverage Δ
all 48.67% <42.62%> (+0.28%) ⬆️
cover 49.09% <42.62%> (+0.31%) ⬆️
crosscover 49.02% <42.62%> (+0.28%) ⬆️
update 12.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
main.go 0.00% <0.00%> (ø)
services/agents/parse_defaults_file.go 20.00% <20.00%> (ø)
services/agents/channel/channel.go 62.28% <100.00%> (+0.43%) ⬆️
services/management/mysql.go 54.54% <100.00%> (+54.54%) ⬆️
services/management/management.go 26.13% <0.00%> (+15.90%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1dded39...f0d0326. Read the comment docs.

@pkadej
Copy link
Contributor Author

pkadej commented May 3, 2022

This pull request is alternative for #1068.

FB failed to run tests because i used forked pmm-managed repository:
Percona-Lab/pmm-submodules#2465
During pmm2-api-tests scripts tries to checkout branch on wrong repository (it should be the forked one):
https://pmm.cd.percona.com/blue/organizations/jenkins/pmm2-api-tests/detail/pmm2-api-tests/9910/pipeline

@pkadej
Copy link
Contributor Author

pkadej commented Jun 15, 2022

Closing because PR from forked pmm-managed repository was merged instead of this one.

#1068

@pkadej pkadej closed this Jun 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants