Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PMM-4879 Support for defaults file parameter. #2465

Closed
wants to merge 1 commit into from
Closed

PMM-4879 Support for defaults file parameter. #2465

wants to merge 1 commit into from

Conversation

pkadej
Copy link

@pkadej pkadej commented Apr 20, 2022 •
edited
Loading

PMM-4879

Build will fail because I cannot use forked version of api (pmm) as dependency in mod.go. To acomplish this, api needs be merged and version of pmm api should be bumped.

This was referenced Apr 20, 2022
Closed
Open
Merged
Open
@pkadej pkadej marked this pull request as ready for review April 20, 2022 09:41
@YaroslavPodorvanov
Copy link

@pkadej see build

commands/management/add_mysql.go:205:4: unknown field 'DefaultsFile' in struct literal of type my_sql.AddMySQLBody

@pkadej
Copy link
Author

pkadej commented Apr 22, 2022

@YaroslavPodorvanov This fails because I cannot use forked version of api (pmm) as dependency in mod.go. Api needs to be merged and then version of pmm api - bumped.
Thanks :-)

@JNKPercona
Copy link
Collaborator

server docker - perconalab/pmm-server-fb:PR-2465-90488f9
client docker - perconalab/pmm-client-fb:PR-2465-90488f9
client - https://s3.us-east-2.amazonaws.com/pmm-build-cache/PR-BUILDS/pmm2-client/pmm2-client-PR-2465-90488f9.tar.gz
Create Staging Instance: https://pmm.cd.percona.com/job/aws-staging-start/parambuild/?DOCKER_VERSION=perconalab/pmm-server-fb:PR-2465-90488f9&CLIENT_VERSION=https://s3.us-east-2.amazonaws.com/pmm-build-cache/PR-BUILDS/pmm2-client/pmm2-client-PR-2465-90488f9.tar.gz

@JNKPercona
Copy link
Collaborator

API tests have failed, Please check: API: https://pmm.cd.percona.com/job/pmm2-api-tests/9910/

@JNKPercona
Copy link
Collaborator

UI tests have failed, Please check: UI: https://pmm.cd.percona.com/job/pmm2-ui-tests/15061/

@pkadej pkadej mentioned this pull request May 3, 2022
Closed
@JNKPercona
Copy link
Collaborator

server docker - perconalab/pmm-server-fb:PR-2465-90488f9
client docker - perconalab/pmm-client-fb:PR-2465-90488f9
client - https://s3.us-east-2.amazonaws.com/pmm-build-cache/PR-BUILDS/pmm2-client/pmm2-client-PR-2465-90488f9.tar.gz
Create Staging Instance: https://pmm.cd.percona.com/job/aws-staging-start/parambuild/?DOCKER_VERSION=perconalab/pmm-server-fb:PR-2465-90488f9&CLIENT_VERSION=https://s3.us-east-2.amazonaws.com/pmm-build-cache/PR-BUILDS/pmm2-client/pmm2-client-PR-2465-90488f9.tar.gz

@JNKPercona
Copy link
Collaborator

API tests have failed, Please check: API: https://pmm.cd.percona.com/job/pmm2-api-tests/9936/

@JNKPercona
Copy link
Collaborator

UI tests have failed, Please check: UI: https://pmm.cd.percona.com/job/pmm2-ui-tests/15260/

@JNKPercona
Copy link
Collaborator

server docker - perconalab/pmm-server-fb:PR-2465-90488f9
client docker - perconalab/pmm-client-fb:PR-2465-90488f9
client - https://s3.us-east-2.amazonaws.com/pmm-build-cache/PR-BUILDS/pmm2-client/pmm2-client-PR-2465-90488f9.tar.gz
Create Staging Instance: https://pmm.cd.percona.com/job/aws-staging-start/parambuild/?DOCKER_VERSION=perconalab/pmm-server-fb:PR-2465-90488f9&CLIENT_VERSION=https://s3.us-east-2.amazonaws.com/pmm-build-cache/PR-BUILDS/pmm2-client/pmm2-client-PR-2465-90488f9.tar.gz

@JNKPercona
Copy link
Collaborator

API tests have failed, Please check: API: https://pmm.cd.percona.com/job/pmm2-api-tests/9937/

@JNKPercona
Copy link
Collaborator

pmm2-client testsuite has failed, Please check: BATS: https://pmm.cd.percona.com/job/pmm2-testsuite/9460/

@JNKPercona
Copy link
Collaborator

UI tests have failed, Please check: UI: https://pmm.cd.percona.com/job/pmm2-ui-tests/15261/

@JNKPercona
Copy link
Collaborator

server docker - perconalab/pmm-server-fb:PR-2465-90488f9
client docker - perconalab/pmm-client-fb:PR-2465-90488f9
client - https://s3.us-east-2.amazonaws.com/pmm-build-cache/PR-BUILDS/pmm2-client/pmm2-client-PR-2465-90488f9.tar.gz
Create Staging Instance: https://pmm.cd.percona.com/job/aws-staging-start/parambuild/?DOCKER_VERSION=perconalab/pmm-server-fb:PR-2465-90488f9&CLIENT_VERSION=https://s3.us-east-2.amazonaws.com/pmm-build-cache/PR-BUILDS/pmm2-client/pmm2-client-PR-2465-90488f9.tar.gz

@JNKPercona
Copy link
Collaborator

API tests have failed, Please check: API: https://pmm.cd.percona.com/job/pmm2-api-tests/9938/

@JNKPercona
Copy link
Collaborator

UI tests have failed, Please check: UI: https://pmm.cd.percona.com/job/pmm2-ui-tests/15262/

@pkadej pkadej force-pushed the PMM-4879-defaults-file branch from 90488f9 to fe16004 Compare May 26, 2022 21:43
@JNKPercona
Copy link
Collaborator

server docker - perconalab/pmm-server-fb:PR-2465-fe16004
client docker - perconalab/pmm-client-fb:PR-2465-fe16004
client - https://s3.us-east-2.amazonaws.com/pmm-build-cache/PR-BUILDS/pmm2-client/pmm2-client-PR-2465-fe16004.tar.gz
Create Staging Instance: https://pmm.cd.percona.com/job/aws-staging-start/parambuild/?DOCKER_VERSION=perconalab/pmm-server-fb:PR-2465-fe16004&CLIENT_VERSION=https://s3.us-east-2.amazonaws.com/pmm-build-cache/PR-BUILDS/pmm2-client/pmm2-client-PR-2465-fe16004.tar.gz

@JNKPercona
Copy link
Collaborator

API tests have failed, Please check: API: https://pmm.cd.percona.com/job/pmm2-api-tests/10142/

@JNKPercona
Copy link
Collaborator

UI tests have failed, Please check: UI: https://pmm.cd.percona.com/job/pmm2-ui-tests/16224/

@pkadej pkadej mentioned this pull request Jun 9, 2022
Merged
@pkadej pkadej closed this Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pkadej @YaroslavPodorvanov @JNKPercona