Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further NPM CLI issue adjustments #8193

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Further NPM CLI issue adjustments #8193

merged 1 commit into from
Jan 31, 2024

Conversation

sschuberth
Copy link
Member

@sschuberth sschuberth commented Jan 30, 2024

Please have a look at the individual commit messages for the details.

The second commits is just a proposal, I'm fine to also drop it again.

@sschuberth sschuberth requested a review from a team as a code owner January 30, 2024 09:35
@sschuberth sschuberth changed the title Firther NPM CLI issue adjustments Further NPM CLI issue adjustments Jan 30, 2024
fviernau
fviernau previously approved these changes Jan 30, 2024
Copy link
Member

@fviernau fviernau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I prefer to have another approval as I'm not certain about using "NPM CLI" as Issue.source. Maybe @mnonnenmacher ?

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (32e0072) 67.16% compared to head (36e397d) 67.16%.
Report is 3 commits behind head on main.

❗ Current head 36e397d differs from pull request most recent head e9e2cd5. Consider uploading reports for the commit e9e2cd5 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #8193   +/-   ##
=========================================
  Coverage     67.16%   67.16%           
  Complexity     2049     2049           
=========================================
  Files           357      357           
  Lines         17158    17158           
  Branches       2461     2461           
=========================================
  Hits          11525    11525           
  Misses         4611     4611           
  Partials       1022     1022           
Flag Coverage Δ
funTest-docker 66.25% <ø> (ø)
funTest-non-docker 33.96% <ø> (ø)
test 36.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

fviernau
fviernau previously approved these changes Jan 30, 2024
@mnonnenmacher
Copy link
Member

LGTM, I prefer to have another approval as I'm not certain about using "NPM CLI" as Issue.source. Maybe @mnonnenmacher ?

I thought about this and am not sure if I like the approach. The reason is that for a user who does not know the background it's not clear why some issues use "NPM" and others "NPM CLI" as source. Also, if you want to filter NPM issues (e.g. in the workbench) you now have potentially two different values for the source to filter by.
Another approach would be to prefix the messages with an explanation, that would not require any background knowledge, for example "The NPM CLI reported the following warning during dependency resolution: ...".

@sschuberth
Copy link
Member Author

I thought about this and am not sure if I like the approach.

Ok, let me just drop the second commit then to simplify the decision making here.

@sschuberth sschuberth force-pushed the npm-cli-severity-docs branch from 36e397d to e9e2cd5 Compare January 31, 2024 06:51
@sschuberth sschuberth enabled auto-merge (rebase) January 31, 2024 06:51
@sschuberth sschuberth requested review from fviernau and a team January 31, 2024 06:51
@sschuberth sschuberth merged commit 3852572 into main Jan 31, 2024
21 checks passed
@sschuberth sschuberth deleted the npm-cli-severity-docs branch January 31, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants