feat(npm): Mark forwarded issues form the NPM CLI

Use "NPM CLI" instead of the package manager name as the issue source to further make these forwarded issues separat from NPM package manager issues. Signed-off-by: Sebastian Schuberth <[email protected]>
oss-review-toolkit · Jan 30, 2024 · 074f522 · 074f522
1 parent e9e2cd5
commit 074f522
Show file tree

Hide file tree

Showing 5 changed files with 23 additions and 23 deletions.
diff --git a/...package-managers/node/src/funTest/assets/projects/synthetic/npm-babel-expected-output.yml b/...package-managers/node/src/funTest/assets/projects/synthetic/npm-babel-expected-output.yml
@@ -7769,23 +7769,23 @@ packages:
     path: ""
 issues:
 - timestamp: "1970-01-01T00:00:00Z"
-  source: "NPM"
+  source: "NPM CLI"
   message: "deprecated [email protected]: Chokidar 2 will break on node v14+. Upgrade\
     \ to chokidar 3 with 15x less dependencies."
   severity: "HINT"
 - timestamp: "1970-01-01T00:00:00Z"
-  source: "NPM"
+  source: "NPM CLI"
   message: "deprecated [email protected]: core-js@<3.3 is no longer maintained and not\
     \ recommended for usage due to the number of issues. Because of the V8 engine\
     \ whims, feature detection in old core-js versions could cause a slowdown up to\
     \ 100x even if nothing is polyfilled. Please, upgrade your dependencies to the\
     \ actual version of core-js."
   severity: "HINT"
 - timestamp: "1970-01-01T00:00:00Z"
-  source: "NPM"
+  source: "NPM CLI"
   message: "deprecated [email protected]: https://github.com/lydell/resolve-url#deprecated"
   severity: "HINT"
 - timestamp: "1970-01-01T00:00:00Z"
-  source: "NPM"
+  source: "NPM CLI"
   message: "deprecated [email protected]: Please see https://github.com/lydell/urix#deprecated"
   severity: "HINT"
diff --git a/...anagers/node/src/funTest/assets/projects/synthetic/npm-expected-output-scope-excludes.yml b/...anagers/node/src/funTest/assets/projects/synthetic/npm-expected-output-scope-excludes.yml
@@ -1152,13 +1152,13 @@ packages:
     path: "types/node"
 issues:
 - timestamp: "1970-01-01T00:00:00Z"
-  source: "NPM"
+  source: "NPM CLI"
   message: "The npm-shrinkwrap.json file was created with an old version of npm, so\
     \ supplemental metadata must be fetched from the registry. This is a one-time\
     \ fix-up, please be patient..."
   severity: "HINT"
 - timestamp: "1970-01-01T00:00:00Z"
-  source: "NPM"
+  source: "NPM CLI"
   message: "deprecated [email protected]: CoffeeScript on NPM has moved to \"coffeescript\"\
     \ (no hyphen)"
   severity: "HINT"
diff --git a/plugins/package-managers/node/src/funTest/assets/projects/synthetic/npm-expected-output.yml b/plugins/package-managers/node/src/funTest/assets/projects/synthetic/npm-expected-output.yml
@@ -1188,13 +1188,13 @@ packages:
     path: "types/node"
 issues:
 - timestamp: "1970-01-01T00:00:00Z"
-  source: "NPM"
+  source: "NPM CLI"
   message: "The <REPLACE_LOCKFILE_NAME> file was created with an old version of npm, so\
     \ supplemental metadata must be fetched from the registry. This is a one-time\
     \ fix-up, please be patient..."
   severity: "HINT"
 - timestamp: "1970-01-01T00:00:00Z"
-  source: "NPM"
+  source: "NPM CLI"
   message: "deprecated [email protected]: CoffeeScript on NPM has moved to \"coffeescript\"\
     \ (no hyphen)"
   severity: "HINT"
diff --git a/...-managers/node/src/funTest/assets/projects/synthetic/npm-version-urls-expected-output.yml b/...-managers/node/src/funTest/assets/projects/synthetic/npm-version-urls-expected-output.yml
@@ -5150,56 +5150,56 @@ packages:
     path: ""
 issues:
 - timestamp: "1970-01-01T00:00:00Z"
-  source: "NPM"
+  source: "NPM CLI"
   message: "deprecated [email protected]: Removed event-stream from gulp-header"
   severity: "HINT"
 - timestamp: "1970-01-01T00:00:00Z"
-  source: "NPM"
+  source: "NPM CLI"
   message: "deprecated [email protected]: Please upgrade to v0.1.7"
   severity: "HINT"
 - timestamp: "1970-01-01T00:00:00Z"
-  source: "NPM"
+  source: "NPM CLI"
   message: "deprecated [email protected]: Please upgrade to v1.0.1"
   severity: "HINT"
 - timestamp: "1970-01-01T00:00:00Z"
-  source: "NPM"
+  source: "NPM CLI"
   message: "deprecated [email protected]: Please upgrade to v0.1.5"
   severity: "HINT"
 - timestamp: "1970-01-01T00:00:00Z"
-  source: "NPM"
+  source: "NPM CLI"
   message: "deprecated [email protected]: Please upgrade to v1.0.1"
   severity: "HINT"
 - timestamp: "1970-01-01T00:00:00Z"
-  source: "NPM"
+  source: "NPM CLI"
   message: "deprecated [email protected]: Legacy versions of mkdirp are no longer supported.\
     \ Please update to mkdirp 1.x. (Note that the API surface has changed to use Promises\
     \ in 1.x.)"
   severity: "HINT"
 - timestamp: "1970-01-01T00:00:00Z"
-  source: "NPM"
+  source: "NPM CLI"
   message: "deprecated [email protected]: https://github.com/lydell/resolve-url#deprecated"
   severity: "HINT"
 - timestamp: "1970-01-01T00:00:00Z"
-  source: "NPM"
+  source: "NPM CLI"
   message: "deprecated [email protected]: See https://github.com/lydell/source-map-resolve#deprecated"
   severity: "HINT"
 - timestamp: "1970-01-01T00:00:00Z"
-  source: "NPM"
+  source: "NPM CLI"
   message: "deprecated [email protected]: See https://github.com/lydell/source-map-url#deprecated"
   severity: "HINT"
 - timestamp: "1970-01-01T00:00:00Z"
-  source: "NPM"
+  source: "NPM CLI"
   message: "deprecated [email protected]: Please see https://github.com/lydell/urix#deprecated"
   severity: "HINT"
 - timestamp: "1970-01-01T00:00:00Z"
-  source: "NPM"
+  source: "NPM CLI"
   message: "skipping integrity check for git dependency ssh://[email protected]/jonschlinkert/gulp-format-md.git "
   severity: "HINT"
 - timestamp: "1970-01-01T00:00:00Z"
-  source: "NPM"
+  source: "NPM CLI"
   message: "skipping integrity check for git dependency ssh://[email protected]/mochajs/mocha.git "
   severity: "HINT"
 - timestamp: "1970-01-01T00:00:00Z"
-  source: "NPM"
+  source: "NPM CLI"
   message: "skipping integrity check for git dependency ssh://[email protected]/tinydesk/angular-tileview.git "
   severity: "HINT"
diff --git a/plugins/package-managers/node/src/main/kotlin/Npm.kt b/plugins/package-managers/node/src/main/kotlin/Npm.kt
@@ -575,12 +575,12 @@ open class Npm(
         // Generally forward issues from the NPM CLI to the ORT NPM package manager. Lower the severity of warnings to
         // hints, as warnings usually do not prevent the ORT NPM package manager from getting the dependencies right.
         lines.groupLines("npm WARN ").mapTo(issues) {
-            Issue(source = managerName, message = it, severity = Severity.HINT)
+            Issue(source = "NPM CLI", message = it, severity = Severity.HINT)
         }
 
         // For errors, however, something clearly went wrong, so keep the severity here.
         lines.groupLines("npm ERR! ").mapTo(issues) {
-            Issue(source = managerName, message = it, severity = Severity.ERROR)
+            Issue(source = "NPM CLI", message = it, severity = Severity.ERROR)
         }
 
         return issues