Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further NPM CLI issue adjustments #8193

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Further NPM CLI issue adjustments #8193

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions plugins/package-managers/node/src/main/kotlin/Npm.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -572,10 +572,13 @@ open class Npm(
val lines = process.stderr.lines()
val issues = mutableListOf<Issue>()

// Generally forward issues from the NPM CLI to the ORT NPM package manager. Lower the severity of warnings to
// hints, as warnings usually do not prevent the ORT NPM package manager from getting the dependencies right.
lines.groupLines("npm WARN ").mapTo(issues) {
Issue(source = managerName, message = it, severity = Severity.HINT)
}

// For errors, however, something clearly went wrong, so keep the severity here.
lines.groupLines("npm ERR! ").mapTo(issues) {
Issue(source = managerName, message = it, severity = Severity.ERROR)
}
Expand Down
Loading