[ROCm] switch rocm build to clang #19660
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alekstheod
force-pushed
the
ci_switch_rocm_build_to_clang
branch
from
cbfc6dd
to
ea48f7c
Compare
beckerhe
reviewed
Nov 22, 2024
beckerhe
approved these changes
Nov 22, 2024
copybara-service bot
pushed a commit
to google/tsl
that referenced
this pull request
Nov 22, 2024
Imported from GitHub PR openxla/xla#19660 This PR switches the default rocm build to clang as the gcc config is broken at the moment. Copybara import of the project: -- ea48f7c480d110eab3f133ed6ea8989da0e1e724 by Alexandros Theodoridis <[email protected]>: [ROCm] switch rocm build to clang -- 2743fabafd6a358c05e858781064e7fa2e389c78 by Alexandros Theodoridis <[email protected]>: Remove explicit clang path from the bazelrc rocm config -- 202dea0a80602cafdbee6067d8f20dc3055c6bbb by Alexandros Theodoridis <[email protected]>: Address review comments Merging this change closes #19660 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#19660 from ROCm:ci_switch_rocm_build_to_clang 202dea0a80602cafdbee6067d8f20dc3055c6bbb PiperOrigin-RevId: 699196393
copybara-service bot
pushed a commit
that referenced
this pull request
Nov 22, 2024
Imported from GitHub PR #19660 This PR switches the default rocm build to clang as the gcc config is broken at the moment. Copybara import of the project: -- ea48f7c by Alexandros Theodoridis <[email protected]>: [ROCm] switch rocm build to clang -- 2743fab by Alexandros Theodoridis <[email protected]>: Remove explicit clang path from the bazelrc rocm config -- 202dea0 by Alexandros Theodoridis <[email protected]>: Address review comments Merging this change closes #19660 FUTURE_COPYBARA_INTEGRATE_REVIEW=#19660 from ROCm:ci_switch_rocm_build_to_clang 202dea0 PiperOrigin-RevId: 699196393
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Nov 22, 2024
Imported from GitHub PR openxla/xla#19660 This PR switches the default rocm build to clang as the gcc config is broken at the moment. Copybara import of the project: -- ea48f7c480d110eab3f133ed6ea8989da0e1e724 by Alexandros Theodoridis <[email protected]>: [ROCm] switch rocm build to clang -- 2743fabafd6a358c05e858781064e7fa2e389c78 by Alexandros Theodoridis <[email protected]>: Remove explicit clang path from the bazelrc rocm config -- 202dea0a80602cafdbee6067d8f20dc3055c6bbb by Alexandros Theodoridis <[email protected]>: Address review comments Merging this change closes #19660 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#19660 from ROCm:ci_switch_rocm_build_to_clang 202dea0a80602cafdbee6067d8f20dc3055c6bbb PiperOrigin-RevId: 699196393
copybara-service bot
pushed a commit
that referenced
this pull request
Nov 22, 2024
Imported from GitHub PR #19660 This PR switches the default rocm build to clang as the gcc config is broken at the moment. Copybara import of the project: -- ea48f7c by Alexandros Theodoridis <[email protected]>: [ROCm] switch rocm build to clang -- 2743fab by Alexandros Theodoridis <[email protected]>: Remove explicit clang path from the bazelrc rocm config -- 202dea0 by Alexandros Theodoridis <[email protected]>: Address review comments Merging this change closes #19660 FUTURE_COPYBARA_INTEGRATE_REVIEW=#19660 from ROCm:ci_switch_rocm_build_to_clang 202dea0 PiperOrigin-RevId: 699196393
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Nov 22, 2024
Imported from GitHub PR openxla/xla#19660 This PR switches the default rocm build to clang as the gcc config is broken at the moment. Copybara import of the project: -- ea48f7c480d110eab3f133ed6ea8989da0e1e724 by Alexandros Theodoridis <[email protected]>: [ROCm] switch rocm build to clang -- 2743fabafd6a358c05e858781064e7fa2e389c78 by Alexandros Theodoridis <[email protected]>: Remove explicit clang path from the bazelrc rocm config -- 202dea0a80602cafdbee6067d8f20dc3055c6bbb by Alexandros Theodoridis <[email protected]>: Address review comments Merging this change closes #19660 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#19660 from ROCm:ci_switch_rocm_build_to_clang 202dea0a80602cafdbee6067d8f20dc3055c6bbb PiperOrigin-RevId: 699196393
copybara-service bot
pushed a commit
to google/tsl
that referenced
this pull request
Nov 22, 2024
Imported from GitHub PR openxla/xla#19660 This PR switches the default rocm build to clang as the gcc config is broken at the moment. Copybara import of the project: -- ea48f7c480d110eab3f133ed6ea8989da0e1e724 by Alexandros Theodoridis <[email protected]>: [ROCm] switch rocm build to clang -- 2743fabafd6a358c05e858781064e7fa2e389c78 by Alexandros Theodoridis <[email protected]>: Remove explicit clang path from the bazelrc rocm config -- 202dea0a80602cafdbee6067d8f20dc3055c6bbb by Alexandros Theodoridis <[email protected]>: Address review comments Merging this change closes #19660 PiperOrigin-RevId: 699222609
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Nov 22, 2024
Imported from GitHub PR openxla/xla#19660 This PR switches the default rocm build to clang as the gcc config is broken at the moment. Copybara import of the project: -- ea48f7c480d110eab3f133ed6ea8989da0e1e724 by Alexandros Theodoridis <[email protected]>: [ROCm] switch rocm build to clang -- 2743fabafd6a358c05e858781064e7fa2e389c78 by Alexandros Theodoridis <[email protected]>: Remove explicit clang path from the bazelrc rocm config -- 202dea0a80602cafdbee6067d8f20dc3055c6bbb by Alexandros Theodoridis <[email protected]>: Address review comments Merging this change closes #19660 PiperOrigin-RevId: 699222609
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches the default rocm build to clang as the gcc config is broken at the moment.