[ROCm] Implement hermetic rocm dependency #19649
Open
+927
−191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
This is really exciting. Thank you. I won't be able to have a look before next week though. |
alekstheod
changed the title
alekstheod
commented
Nov 27, 2024
alekstheod
force-pushed
the
ci_implement_hermetic_rocm_dependency_upstream
branch
from
5a1694b
to
d3db2bd
Compare
alekstheod
force-pushed
the
ci_implement_hermetic_rocm_dependency_upstream
branch
2 times, most recently
from
5c0c0da
to
3002fbc
Compare
alekstheod
force-pushed
the
ci_implement_hermetic_rocm_dependency_upstream
branch
from
3002fbc
to
c4672b6
Compare
JehandadKhan
reviewed
Dec 2, 2024
| "6.2.0": { | ||
| "archives": [ | ||
| struct( | ||
| url = "https://repo.radeon.com/rocm/apt/6.2/pool/main/c/comgr6.2.0/comgr6.2.0_2.8.0.60200-66~20.04_amd64.deb", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change has as a goal to introduce an external dependency to the rocm library and tools.
Building xla with the hermetic rocm is done by using these env variables:
--repo_env=OS=ubuntu_20.04
--repo_env=ROCM_VERSION=6.2.0
One has to provie OS version and ROCm version to initialize a proper rocm repository.
If these flags are not set then default ROCm installation will be used to build XLA.
depends-on: #19691